You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/21 19:52:51 UTC

[GitHub] [activemq-artemis] jbertram opened a new pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

jbertram opened a new pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666


   This is a follow-up from ARTEMIS-2322.
   
   The changes related to expired message are only there because
   QueueFilterPredicate had a bug where the rate was correlated to expired
   messages. When I fixed that I noticed that expired messages was actually
   missing so I added it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666#issuecomment-887876315


   fair enough. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666#issuecomment-884523343


   This is quite a public breaking change though. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666#issuecomment-884468973


   @michaelandrepearce, check the commit message for 246bf083914c7acbb05a7fe0904c471331242c39 from ARTEMIS-2322. Hopefully that explains the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666#issuecomment-884461572


   Ill be honest i dont understand the removal of this. If theres a bug fix it. But dont remove 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3666: ARTEMIS-3397 remove queue rate metric from web console

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3666:
URL: https://github.com/apache/activemq-artemis/pull/3666#issuecomment-884623737


   A few points...
   
   1. The "rate" was never meant to be user facing. It was designed to be used exclusively for slow-consumer detection (i.e. `org.apache.activemq.artemis.core.server.impl.QueueImpl.SlowConsumerReaperRunnable`). Calling it from other places can break slow-consumer detection and result in false negatives. I made a mistake by adding `getRate()` to the `org.apache.activemq.artemis.core.server.Queue` interface. It should always have been `private`. I fixed that in this PR.
   2. The "rate" was exposed originally on the web console by mistake via [ARTEMIS-1349](https://issues.apache.org/jira/browse/ARTEMIS-1349) in 2.3.0. It was likely included in `org.apache.activemq.artemis.core.management.impl.view.QueueView` because `getRate()` was on the `Queue` interface.
   3. A corresponding JMX attribute was mistakenly added in 2.10.0 via [ARTEMIS-2322](https://issues.apache.org/jira/browse/ARTEMIS-2322) and then removed in 2.16.0 via [ARTEMIS-2909](https://issues.apache.org/jira/browse/ARTEMIS-2909). I've heard no complaints since then. I didn't even realize it was exposed on the web console until recently otherwise I would have removed it when I removed the JMX attribute.
   4. I think it's unlikely that "rate" is widely used given it was never properly documented and exhibits strange behavior (e.g. consecutive calls to `getRate()` can return widely varying results unless the rate of production is extremely consistent over time, especially if any other user or system is also polling it).
   5. Better alternatives exists as outlined in 246bf083914c7acbb05a7fe0904c471331242c39.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org