You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/05/06 08:41:18 UTC

[GitHub] [cassandra-dtest] bereng opened a new pull request, #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

bereng opened a new pull request, #193:
URL: https://github.com/apache/cassandra-dtest/pull/193

   …mv_with_default_ttl_with_flush


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-dtest] bereng commented on pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

Posted by GitBox <gi...@apache.org>.
bereng commented on PR #193:
URL: https://github.com/apache/cassandra-dtest/pull/193#issuecomment-1119389914

   CI [here](https://app.circleci.com/pipelines/github/bereng/cassandra/654/workflows/6cbcc08b-ca87-44b5-9ea1-5ae04574217f/jobs/5950)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-dtest] bereng commented on pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

Posted by GitBox <gi...@apache.org>.
bereng commented on PR #193:
URL: https://github.com/apache/cassandra-dtest/pull/193#issuecomment-1124560061

   CI [here](https://app.circleci.com/pipelines/github/bereng/cassandra/656/workflows/ef05cbed-9c9f-4451-8f96-9ad7f9a441eb)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-dtest] bereng closed pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

Posted by GitBox <gi...@apache.org>.
bereng closed pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…
URL: https://github.com/apache/cassandra-dtest/pull/193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-dtest] bereng commented on a diff in pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

Posted by GitBox <gi...@apache.org>.
bereng commented on code in PR #193:
URL: https://github.com/apache/cassandra-dtest/pull/193#discussion_r870298939


##########
materialized_views_test.py:
##########
@@ -1399,22 +1399,49 @@ def _test_mv_with_default_ttl(self, flush):
             assert_one(session, "SELECT * FROM mv", [1, 3, 1])
 
         # user provided ttl
-        self.update_view(session, "UPDATE t USING TTL 50 SET a = 4 WHERE k = 1", flush)
-        assert_one(session, "SELECT * FROM t", [1, 4, 1])
-        assert_one(session, "SELECT * FROM mv", [1, 4, 1])
+        start = time.time()
+        self.update_view(session, "UPDATE t USING TTL 100 SET a = 4 WHERE k = 1", flush)
+        try:
+            assert_one(session, "SELECT * FROM t", [1, 4, 1])
+            assert_one(session, "SELECT * FROM mv", [1, 4, 1])
+        except AssertionError as ae:
+            if (time.time() - start) > 100:

Review Comment:
   They could. I can change that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-dtest] bereng commented on pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

Posted by GitBox <gi...@apache.org>.
bereng commented on PR #193:
URL: https://github.com/apache/cassandra-dtest/pull/193#issuecomment-1123252676

   CI [LGTM](https://app.circleci.com/pipelines/github/bereng/cassandra/655/workflows/badbea6a-00e2-40ed-aacf-89b491229d0a/jobs/5952)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-dtest] adelapena commented on a diff in pull request #193: Fix dtest-offheap.materialized_views_test.TestMaterializedViews.test_…

Posted by GitBox <gi...@apache.org>.
adelapena commented on code in PR #193:
URL: https://github.com/apache/cassandra-dtest/pull/193#discussion_r870189391


##########
materialized_views_test.py:
##########
@@ -1399,22 +1399,49 @@ def _test_mv_with_default_ttl(self, flush):
             assert_one(session, "SELECT * FROM mv", [1, 3, 1])
 
         # user provided ttl
-        self.update_view(session, "UPDATE t USING TTL 50 SET a = 4 WHERE k = 1", flush)
-        assert_one(session, "SELECT * FROM t", [1, 4, 1])
-        assert_one(session, "SELECT * FROM mv", [1, 4, 1])
+        start = time.time()
+        self.update_view(session, "UPDATE t USING TTL 100 SET a = 4 WHERE k = 1", flush)
+        try:
+            assert_one(session, "SELECT * FROM t", [1, 4, 1])
+            assert_one(session, "SELECT * FROM mv", [1, 4, 1])
+        except AssertionError as ae:
+            if (time.time() - start) > 100:

Review Comment:
   Shouldn't all these inequalities be `>=`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org