[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

[GitBox <gi...@apache.org>]

mocobeta commented on a change in pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#discussion_r495706327



##########
File path: lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamFactoryTestCase.java
##########
@@ -39,10 +39,6 @@
  *   assertTokenStreamContents(stream, new String[] { "some", "text", "to", "analyze" });
  * </pre>
  */
-// TODO: this has to be here, since the abstract factories are not in lucene-core,
-// so test-framework doesnt know about them...
-// this also means we currently cannot use this in other analysis modules :(
-// TODO: maybe after we improve the abstract factory/SPI apis, they can sit in core and resolve this.

Review comment:
       This is finally moved to test-framework from analyzers-common. :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org