You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/25 16:39:23 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #24657: Fix behaviour of build/pull after recent Breeze changes

potiuk commented on code in PR #24657:
URL: https://github.com/apache/airflow/pull/24657#discussion_r906701977


##########
dev/breeze/src/airflow_breeze/commands/ci_image_commands.py:
##########
@@ -605,4 +613,5 @@ def rebuild_or_pull_ci_image_if_needed(
             'Forcing build.[/]'
         )
         ci_image_params.force_build = True
-    run_build_ci_image(verbose, dry_run=dry_run, ci_image_params=ci_image_params, parallel=False)
+    if start_building(ci_image_params=ci_image_params, dry_run=dry_run, verbose=verbose):

Review Comment:
   Here we missed a check if image should be built.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org