[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on a change in pull request #420:
URL: https://github.com/apache/solr/pull/420#discussion_r761497602



##########
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/ReplaceNodeCmd.java
##########
@@ -96,35 +97,47 @@ public void call(ClusterState state, ZkNodeProps message, NamedList<Object> resu
     // map of collectionName_coreNodeName to watchers
     Map<String, CollectionStateWatcher> watchers = new HashMap<>();
     List<ZkNodeProps> createdReplicas = new ArrayList<>();
+    List<Replica> createdReplicaObjects = new ArrayList<>();

Review comment:
       *ModifiedButNotUsed:*  A collection or proto builder was created, but its values were never accessed. [(details)](https://errorprone.info/bugpattern/ModifiedButNotUsed)
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org