You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Renkai <gi...@git.apache.org> on 2015/08/26 11:58:58 UTC
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
GitHub user Renkai opened a pull request:
https://github.com/apache/storm/pull/699
[STORM-1010] each KafkaBolt have its own properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Renkai/storm dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/699.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #699
----
commit a062a40845a808566c8d727a654654a47e8d3eb3
Author: renkai <ga...@gmail.com>
Date: 2015-08-26T09:55:16Z
each KafkaBolt have its own properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135165749
@revans2 @Renkai makes sense. Instead of using constructor can we should with Options like other bolts are using. probably "withProducerProperties" method and remove the topology level configs so that there isn't two ways configure the bolt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135152145
The changes look fine to me. +1
@harshach we did a similar thing for the HDFS Bolt.
https://github.com/apache/storm/blob/ffb1562cb0eb3fbd916423136fcd3c181fbf6212/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java#L53-L56
Each bolt needs to be able to be configured independently of all other bolts. Putting it in the conf is a is one way to do it, but I have seen a lot of bolts do it through a setter too. I personally would prefer to support both through a config and through an API. The only trick is with consistency and ordering in the case of conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135165221
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135286772
@Renkai those failed tests are intermittent test failures in storm-core not related to the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by Renkai <gi...@git.apache.org>.
Github user Renkai commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135233931
Travis CI shows test fails in with jdk8,but I think it's not problems with my commits,tests all passed on my Mac.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135050335
@Renkai whats the need for this? why can't you add multiple bolts with its own parallelism. IMO this goes against the storm api.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by Renkai <gi...@git.apache.org>.
Github user Renkai commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135222309
@harshach I will push another merge requests,make it harmonic with current code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135578511
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by Renkai <gi...@git.apache.org>.
Github user Renkai commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135067844
@harshach
Different KafkaBolts may need to send topic to different kafka clusters,use different serializers,and have different params for performance tunning.
In current version there is no way to do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135173459
I am fine with the current approach but we need to standardize one way configuring the bolts as each connector follows its own pattern right now and which can be confusing to the users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---