You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/31 23:29:27 UTC

[jira] [Commented] (DRILL-4000) In all non-root fragments, Drill recreates storage plugin instances for every minor fragment

    [ https://issues.apache.org/jira/browse/DRILL-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984196#comment-14984196 ] 

ASF GitHub Bot commented on DRILL-4000:
---------------------------------------

GitHub user jacques-n opened a pull request:

    https://github.com/apache/drill/pull/227

    DRILL-4000: Ensure storage plugins are not needlessly created. Add st…

    …art and close capability to storage plugins.
    
    Add a new configuration based map so any configurations that are passed to a node can leverage existing storage plugins.
    Update FileSystemConfig to correctly implement hashcode()
    Update StoragePlugin interface to extends Autocloseable and add start() method.
    Update Mongo plugin to close clients when closing plugin.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jacques-n/drill DRILL-4000

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #227
    
----
commit 7b60adfc6f5fa5139709ef2ce618fb92d9e97159
Author: Jacques Nadeau <ja...@apache.org>
Date:   2015-10-31T22:16:32Z

    DRILL-4000: Ensure storage plugins are not needlessly created. Add start and close capability to storage plugins.
    
    Add a new configuration based map so any configurations that are passed to a node can leverage existing storage plugins.
    Update FileSystemConfig to correctly implement hashcode()
    Update StoragePlugin interface to extends Autocloseable and add start() method.
    Update Mongo plugin to close clients when closing plugin.

----


> In all non-root fragments, Drill recreates storage plugin instances for every minor fragment
> --------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4000
>                 URL: https://issues.apache.org/jira/browse/DRILL-4000
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Jacques Nadeau
>            Assignee: Jacques Nadeau
>             Fix For: 1.3.0
>
>
> Drill is creating ephemeral storage plugin instances when a plan is deserialized. As such, every minor fragment of a query has Drill create a separate storage plugin instance. Depending on the cost of storage plugin creation, this could be quite expensive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)