[jira] [Resolved] (LUCENE-10433) we should pass l instead of d to getFallbackSelector(d).select in RadixSelector.select()

["kkewwei (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

kkewwei resolved LUCENE-10433.
------------------------------
    Resolution: Resolved

> we should pass l instead of d to getFallbackSelector(d).select in RadixSelector.select()
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10433
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10433
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/other
>    Affects Versions: 8.6.2
>            Reporter: kkewwei
>            Priority: Major
>
> In the `RadixSelector.select`
> {code:java}
>   private void select(int from, int to, int k, int d, int l) {
>     if (to - from <= LENGTH_THRESHOLD || d >= LEVEL_THRESHOLD) { 
>       getFallbackSelector(d).select(from, to, k); 
>     } else {
>       radixSelect(from, to, k, d, l); 
>     }
>   }
> {code}
> we know that `l` represent the levels of recursion, not the `d`, but when we check the levels of recursion, we use `d >= LEVEL_THRESHOLD`, it's not right.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org