You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Jean-Baptiste Onofré (Jira)" <ji...@apache.org> on 2020/03/22 17:20:00 UTC
[jira] [Commented] (KARAF-6651) The provided build command for pull
requests in the contribution guide fails
[ https://issues.apache.org/jira/browse/KARAF-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064347#comment-17064347 ]
Jean-Baptiste Onofré commented on KARAF-6651:
---------------------------------------------
Actually, it's not required the use the full {{release}} profile. I will replace with {{-Prat}} which is enough to execute on a PR.
> The provided build command for pull requests in the contribution guide fails
> ----------------------------------------------------------------------------
>
> Key: KARAF-6651
> URL: https://issues.apache.org/jira/browse/KARAF-6651
> Project: Karaf
> Issue Type: Documentation
> Components: website
> Environment: macOS Mojave 10.14.6
> Model Name: MacBook Pro
> Model Identifier: MacBookPro15,1
> Processor Name: Intel Core i7
> Processor Speed: 2,6 GHz
> Number of Processors: 1
> Total Number of Cores: 6
> L2 Cache (per Core): 256 KB
> L3 Cache: 12 MB
> Hyper-Threading Technology: Enabled
> Memory: 32 GB
> java version "1.8.0_231"
> Java(TM) SE Runtime Environment (build 1.8.0_231-b11)
> Java HotSpot(TM) 64-Bit Server VM (build 25.231-b11, mixed mode)
> Apache Maven 3.6.3
> Reporter: Oliver Limberg
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
>
> The guide states to run
> {code:bash}
> mvn clean verify -Prelease -fae -T 1C
> {code}
> before submitting a pull request.
> Assuming the user only completed the tasks from BUILDING.md, this will probably always fail, because of the 'sign' goal of the included Apache Maven GPG Plugin.
> I spent quite a few hours now to get this working.
> Other users willing to provide pull requests might not have the patience.
> Is signing the artifacts in this case really required? If not, the command should include
> {code:bash}
> -Dgpg.skip=true{code}
> Otherwise, BUILDING.md should contain a section about installing GPG and creating a key as well.
> I do not know if this is specific to my system, but I had to create a settings.xml file for maven to contain the passphrase for my GPG key and had to remove the maven options for parallel builds as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)