You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/13 04:15:48 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #13078: [FLINK-18659][hive][orc] Fix streaming write for Hive 1.x Orc table
JingsongLi commented on a change in pull request #13078:
URL: https://github.com/apache/flink/pull/13078#discussion_r469686544
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java
##########
@@ -252,32 +252,45 @@ public void testBatchAppend() {
@Test(timeout = 120000)
public void testDefaultSerPartStreamingWrite() throws Exception {
- testStreamingWrite(true, false, true, this::checkSuccessFiles);
+ testStreamingWrite(true, false, "textfile", this::checkSuccessFiles);
}
@Test(timeout = 120000)
public void testPartStreamingWrite() throws Exception {
- testStreamingWrite(true, false, false, this::checkSuccessFiles);
+ testStreamingWrite(true, false, "parquet", this::checkSuccessFiles);
+ // disable orc test for hive 2.x due to dependency conflict
+ if (!hiveCatalog.getHiveVersion().startsWith("2.")) {
Review comment:
Why dependency conflict? Can we make it correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org