You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/16 12:15:39 UTC
[GitHub] [shardingsphere] shreya024 opened a new pull request #16137: Condition value Generator Factory test file added
shreya024 opened a new pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137
Fixes #16105 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070525159
@shreya024 Please fix the ci error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
shreya024 commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070540345
> @shreya024 Please fix the ci error.
The CI s have passed.2 Integration tests are giving error.Kindly guide me how to resolve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070570487
@shreya024
Is this command succeed?
```
mvn -T 1C clean install
```
If is, may be someone else code couse this error.
try pull master, and push again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
shreya024 commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070816412
> @shreya024 Is this command succeed?
>
> ```
> mvn -T 1C clean install
> ```
>
> If is, may be someone else code couse this error. try pull master, and push again
Unable to find error.Build success and tests running successfully in IntelliJ Local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1071163967
@shreya024 nice work, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1071163967
@shreya024 nice work, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 removed a comment on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
shreya024 removed a comment on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070816412
> @shreya024 Is this command succeed?
>
> ```
> mvn -T 1C clean install
> ```
>
> If is, may be someone else code couse this error. try pull master, and push again
Unable to find error.Build success and tests running successfully in IntelliJ Local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1071095023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16137](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (971e3e8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9da3f16b2ade3db55c8d83e31fd695d38dbfa12d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9da3f16) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16137 +/- ##
============================================
+ Coverage 60.43% 60.45% +0.02%
Complexity 2053 2053
============================================
Files 3286 3286
Lines 49626 49629 +3
Branches 8536 8539 +3
============================================
+ Hits 29990 30004 +14
+ Misses 17118 17106 -12
- Partials 2518 2519 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...min/postgresql/PostgreSQLAdminExecutorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16137/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvUG9zdGdyZVNRTEFkbWluRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `61.29% <0.00%> (+25.57%)` | :arrow_up: |
| [...tion/generator/ConditionValueGeneratorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16137/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9nZW5lcmF0b3IvQ29uZGl0aW9uVmFsdWVHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <0.00%> (+28.57%)` | :arrow_up: |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/16137/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9da3f16...971e3e8](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 removed a comment on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
shreya024 removed a comment on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070816412
> @shreya024 Is this command succeed?
>
> ```
> mvn -T 1C clean install
> ```
>
> If is, may be someone else code couse this error. try pull master, and push again
Unable to find error.Build success and tests running successfully in IntelliJ Local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1071095023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16137](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (971e3e8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9da3f16b2ade3db55c8d83e31fd695d38dbfa12d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9da3f16) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16137 +/- ##
============================================
+ Coverage 60.43% 60.45% +0.02%
Complexity 2053 2053
============================================
Files 3286 3286
Lines 49626 49629 +3
Branches 8536 8539 +3
============================================
+ Hits 29990 30004 +14
+ Misses 17118 17106 -12
- Partials 2518 2519 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...min/postgresql/PostgreSQLAdminExecutorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16137/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL3Bvc3RncmVzcWwvUG9zdGdyZVNRTEFkbWluRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `61.29% <0.00%> (+25.57%)` | :arrow_up: |
| [...tion/generator/ConditionValueGeneratorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16137/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9nZW5lcmF0b3IvQ29uZGl0aW9uVmFsdWVHZW5lcmF0b3JGYWN0b3J5LmphdmE=) | `71.42% <0.00%> (+28.57%)` | :arrow_up: |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/16137/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9da3f16...971e3e8](https://codecov.io/gh/apache/shardingsphere/pull/16137?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
shreya024 commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070816412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 commented on pull request #16137: Condition value Generator Factory test file added
Posted by GitBox <gi...@apache.org>.
shreya024 commented on pull request #16137:
URL: https://github.com/apache/shardingsphere/pull/16137#issuecomment-1070922038
> @shreya024 Is this command succeed?
>
> ```
> mvn -T 1C clean install
> ```
>
> If is, may be someone else code couse this error. try pull master, and push again
Okay Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org