You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/03 06:35:34 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #230: chore: remove ApisixService CRD
tokers opened a new pull request #230:
URL: https://github.com/apache/apisix-ingress-controller/pull/230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #230: chore: remove ApisixService CRD
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #230:
URL: https://github.com/apache/apisix-ingress-controller/pull/230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #230: chore: remove ApisixService CRD
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #230:
URL: https://github.com/apache/apisix-ingress-controller/pull/230#issuecomment-772276916
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=h1) Report
> Merging [#230](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=desc) (bed7f6f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b51bd46e17235be589979f503ab56dd927cf5d07?el=desc) (b51bd46) will **increase** coverage by `54.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #230 +/- ##
============================================
+ Coverage 45.58% 100.00% +54.41%
============================================
Files 34 1 -33
Lines 2029 1 -2028
============================================
- Hits 925 1 -924
+ Misses 968 0 -968
+ Partials 136 0 -136
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | | |
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | | |
| [pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2V2ZW50Lmdv) | | |
| [pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv) | | |
| [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | |
| [pkg/log/options.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2xvZy9vcHRpb25zLmdv) | | |
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | | |
| ... and [21 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=footer). Last update [b51bd46...bed7f6f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #230: chore: remove ApisixService CRD
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #230:
URL: https://github.com/apache/apisix-ingress-controller/pull/230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #230: chore: remove ApisixService CRD
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #230:
URL: https://github.com/apache/apisix-ingress-controller/pull/230#issuecomment-772276916
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=h1) Report
> Merging [#230](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=desc) (e832b70) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c786e083d3dc9bc4b1e8c2e2b9e7a099da6c88e5?el=desc) (c786e08) will **increase** coverage by `55.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #230 +/- ##
============================================
+ Coverage 44.48% 100.00% +55.51%
============================================
Files 34 1 -33
Lines 2050 1 -2049
============================================
- Hits 912 1 -911
+ Misses 995 0 -995
+ Partials 143 0 -143
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | | |
| [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | | |
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | | |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | | |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | | |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | | |
| [pkg/log/logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | | |
| [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | | |
| ... and [21 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=footer). Last update [c786e08...e832b70](https://codecov.io/gh/apache/apisix-ingress-controller/pull/230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org