You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/18 14:07:31 UTC
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6175: [INLONG-6045][Sort] Support all migrate for Oracle connector
yunqingmoswu commented on code in PR #6175:
URL: https://github.com/apache/inlong/pull/6175#discussion_r998281899
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleTableSourceFactory.java:
##########
@@ -95,6 +95,12 @@ public class OracleTableSourceFactory implements DynamicTableSourceFactory {
"Optional startup mode for Oracle CDC consumer, valid enumerations are "
+ "\"initial\", \"latest-offset\"");
+ public static final ConfigOption<Boolean> MIGRATE_ALL =
Review Comment:
Maybe it is can also extracted to class Constants of the mode 'base'?
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleTableSourceFactory.java:
##########
@@ -95,6 +95,12 @@ public class OracleTableSourceFactory implements DynamicTableSourceFactory {
"Optional startup mode for Oracle CDC consumer, valid enumerations are "
+ "\"initial\", \"latest-offset\"");
+ public static final ConfigOption<Boolean> MIGRATE_ALL =
+ ConfigOptions.key("migrate-all")
Review Comment:
Maybe it is better to call 'source.multiple.enable'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org