[skywalking-query-protocol] branch wu-sheng-patch-1 created (now f3ff491)

[wu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch wu-sheng-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git.


      at f3ff491  Rollback to re-enable `normal` concept.

This branch includes the following new commits:

     new f3ff491  Rollback to re-enable `normal` concept.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[skywalking-query-protocol] 01/01: Rollback to re-enable `normal` concept.

[wu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch wu-sheng-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git

commit f3ff491330c667ea97e2327cd920bf526c3ae70e
Author: 吴晟 Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Dec 30 08:33:47 2021 +0800

    Rollback to re-enable `normal` concept.
---
 metrics-v2.graphqls | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/metrics-v2.graphqls b/metrics-v2.graphqls
index be5b4a3..d1cf512 100644
--- a/metrics-v2.graphqls
+++ b/metrics-v2.graphqls
@@ -18,10 +18,6 @@
 # defined in the metric.graphql, top-n-records.graphqls, and aggregation.graphqls.
 # By leveraging the new ID rule(no register) in the v8, we could query metrics based on name(s) directly.
 
-# Metrics v2.1 is introduced since SkyWalking v9 core.
-# Change logs:
-# - The normal and destNormal tags have been deprecated.
-
 # Metrics type is a new concept since v8.
 enum MetricsType {
     # Can't find the metrics type definition.
@@ -46,16 +42,17 @@ input Entity {
     #    set necessary names of sources and destinations.
     scope: Scope!
     serviceName: String
+    # Normal service is the service having installed agent or metrics reported directly.
+    # Unnormal service is conjectural service, usually detected by the agent.
+    normal: Boolean
     serviceInstanceName: String
     endpointName: String
     destServiceName: String
+    # Normal service is the service having installed agent or metrics reported directly.
+    # Unnormal service is conjectural service, usually detected by the agent.
+    destNormal: Boolean
     destServiceInstanceName: String
     destEndpointName: String
-
-    # Deprecated since 9.0.0. Don't need to use this anymore
-    normal: Boolean
-    # Deprecated since 9.0.0. Don't need to use this anymore
-    destNormal: Boolean
 }
 
 input MetricsCondition {
@@ -73,15 +70,15 @@ input TopNCondition {
     name: String!
     # Could be null if query the global top N.
     parentService: String
+    # Normal service is the service having installed agent or metrics reported directly.
+    # Unnormal service is conjectural service, usually detected by the agent.
+    normal: Boolean
     # Indicate the metrics entity scope.
     # This is required in sortMetrics query.
     # Only accept scope = Service/ServiceInstance/Endpoint, ignore others due to those are pointless.
     scope: Scope
     topN: Int!
     order: Order!
-
-    # Deprecated since 9.0.0. Don't need to use this anymore
-    normal: Boolean
 }
 
 # Define the metrics provided in the OAP server.