You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/06/01 18:46:18 UTC

[tomcat] branch 9.0.x updated: Code clean-up - formatting. No functional change.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 0b2c5177d7 Code clean-up - formatting. No functional change.
0b2c5177d7 is described below

commit 0b2c5177d71d1dc58e551877b88cb5b0b492f4e4
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Jun 1 19:46:11 2023 +0100

    Code clean-up - formatting. No functional change.
---
 java/org/apache/catalina/connector/Connector.java  |  8 ++--
 .../apache/catalina/connector/CoyoteAdapter.java   |  4 +-
 .../org/apache/catalina/connector/InputBuffer.java |  2 +-
 .../apache/catalina/connector/OutputBuffer.java    |  2 +-
 java/org/apache/catalina/connector/Request.java    | 46 +++++++++++-----------
 .../apache/catalina/connector/RequestFacade.java   |  8 ++--
 java/org/apache/catalina/connector/Response.java   |  8 ++--
 .../apache/catalina/connector/ResponseFacade.java  |  4 +-
 8 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/java/org/apache/catalina/connector/Connector.java b/java/org/apache/catalina/connector/Connector.java
index 7339f961b2..64440c5020 100644
--- a/java/org/apache/catalina/connector/Connector.java
+++ b/java/org/apache/catalina/connector/Connector.java
@@ -63,8 +63,8 @@ public class Connector extends LifecycleMBeanBase {
     /**
      * Alternate flag to enable recycling of facades.
      */
-    public static final boolean RECYCLE_FACADES = Boolean
-            .parseBoolean(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES", "false"));
+    public static final boolean RECYCLE_FACADES =
+            Boolean.parseBoolean(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES", "false"));
 
 
     public static final String INTERNAL_EXECUTOR_NAME = "Internal";
@@ -257,8 +257,8 @@ public class Connector extends LifecycleMBeanBase {
      * The behavior when an encoded solidus (slash) is submitted.
      */
     @SuppressWarnings("deprecation")
-    private EncodedSolidusHandling encodedSolidusHandling = UDecoder.ALLOW_ENCODED_SLASH ? EncodedSolidusHandling.DECODE
-            : EncodedSolidusHandling.REJECT;
+    private EncodedSolidusHandling encodedSolidusHandling =
+            UDecoder.ALLOW_ENCODED_SLASH ? EncodedSolidusHandling.DECODE : EncodedSolidusHandling.REJECT;
 
 
     /**
diff --git a/java/org/apache/catalina/connector/CoyoteAdapter.java b/java/org/apache/catalina/connector/CoyoteAdapter.java
index 4fc929c85b..6693d9cee7 100644
--- a/java/org/apache/catalina/connector/CoyoteAdapter.java
+++ b/java/org/apache/catalina/connector/CoyoteAdapter.java
@@ -913,8 +913,8 @@ public class CoyoteAdapter implements Adapter {
             int end = uriBC.getEnd();
 
             int pathParamStart = semicolon + 1;
-            int pathParamEnd = ByteChunk.findBytes(uriBC.getBuffer(), start + pathParamStart, end,
-                    new byte[] { ';', '/' });
+            int pathParamEnd =
+                    ByteChunk.findBytes(uriBC.getBuffer(), start + pathParamStart, end, new byte[] { ';', '/' });
 
             String pv = null;
 
diff --git a/java/org/apache/catalina/connector/InputBuffer.java b/java/org/apache/catalina/connector/InputBuffer.java
index 5d3554c6d8..00a95a8620 100644
--- a/java/org/apache/catalina/connector/InputBuffer.java
+++ b/java/org/apache/catalina/connector/InputBuffer.java
@@ -69,7 +69,7 @@ public class InputBuffer extends Reader implements ByteChunk.ByteInputChannel, A
     /**
      * Encoder cache.
      */
-    private static final Map<Charset, SynchronizedStack<B2CConverter>> encoders = new ConcurrentHashMap<>();
+    private static final Map<Charset,SynchronizedStack<B2CConverter>> encoders = new ConcurrentHashMap<>();
 
     // ----------------------------------------------------- Instance Variables
 
diff --git a/java/org/apache/catalina/connector/OutputBuffer.java b/java/org/apache/catalina/connector/OutputBuffer.java
index 715da5a7d3..363bcf3de5 100644
--- a/java/org/apache/catalina/connector/OutputBuffer.java
+++ b/java/org/apache/catalina/connector/OutputBuffer.java
@@ -55,7 +55,7 @@ public class OutputBuffer extends Writer {
     /**
      * Encoder cache.
      */
-    private final Map<Charset, C2BConverter> encoders = new HashMap<>();
+    private final Map<Charset,C2BConverter> encoders = new HashMap<>();
 
 
     /**
diff --git a/java/org/apache/catalina/connector/Request.java b/java/org/apache/catalina/connector/Request.java
index 666c67ef4c..1b76bc5a7e 100644
--- a/java/org/apache/catalina/connector/Request.java
+++ b/java/org/apache/catalina/connector/Request.java
@@ -208,10 +208,10 @@ public class Request implements HttpServletRequest {
     protected final SimpleDateFormat formats[];
 
     @Deprecated
-    private static final SimpleDateFormat formatsTemplate[] = {
-            new SimpleDateFormat(FastHttpDateFormat.RFC1123_DATE, Locale.US),
-            new SimpleDateFormat("EEEEEE, dd-MMM-yy HH:mm:ss zzz", Locale.US),
-            new SimpleDateFormat("EEE MMMM d HH:mm:ss yyyy", Locale.US) };
+    private static final SimpleDateFormat formatsTemplate[] =
+            { new SimpleDateFormat(FastHttpDateFormat.RFC1123_DATE, Locale.US),
+                    new SimpleDateFormat("EEEEEE, dd-MMM-yy HH:mm:ss zzz", Locale.US),
+                    new SimpleDateFormat("EEE MMMM d HH:mm:ss yyyy", Locale.US) };
 
 
     /**
@@ -223,7 +223,7 @@ public class Request implements HttpServletRequest {
     /**
      * The attributes associated with this Request, keyed by attribute name.
      */
-    private final Map<String, Object> attributes = new ConcurrentHashMap<>();
+    private final Map<String,Object> attributes = new ConcurrentHashMap<>();
 
 
     /**
@@ -242,7 +242,7 @@ public class Request implements HttpServletRequest {
     /**
      * Internal notes associated with this request by Catalina components and event listeners.
      */
-    private final transient HashMap<String, Object> notes = new HashMap<>();
+    private final transient HashMap<String,Object> notes = new HashMap<>();
 
 
     /**
@@ -333,7 +333,7 @@ public class Request implements HttpServletRequest {
     /**
      * Hash map used in the getParametersMap method.
      */
-    protected ParameterMap<String, String[]> parameterMap = new ParameterMap<>();
+    protected ParameterMap<String,String[]> parameterMap = new ParameterMap<>();
 
 
     /**
@@ -1129,7 +1129,7 @@ public class Request implements HttpServletRequest {
      * @return A <code>Map</code> containing parameter names as keys and parameter values as map values.
      */
     @Override
-    public Map<String, String[]> getParameterMap() {
+    public Map<String,String[]> getParameterMap() {
 
         if (parameterMap.isLocked()) {
             return parameterMap;
@@ -1606,8 +1606,8 @@ public class Request implements HttpServletRequest {
         if ((listeners == null) || (listeners.length == 0)) {
             return;
         }
-        ServletRequestAttributeEvent event = new ServletRequestAttributeEvent(context.getServletContext(), getRequest(),
-                name, value);
+        ServletRequestAttributeEvent event =
+                new ServletRequestAttributeEvent(context.getServletContext(), getRequest(), name, value);
         for (Object o : listeners) {
             if (!(o instanceof ServletRequestAttributeListener)) {
                 continue;
@@ -1972,11 +1972,11 @@ public class Request implements HttpServletRequest {
 
 
     @Override
-    public Map<String, String> getTrailerFields() {
+    public Map<String,String> getTrailerFields() {
         if (!isTrailerFieldsReady()) {
             throw new IllegalStateException(sm.getString("coyoteRequest.trailersNotReady"));
         }
-        Map<String, String> result = new HashMap<>(coyoteRequest.getTrailerFields());
+        Map<String,String> result = new HashMap<>(coyoteRequest.getTrailerFields());
         return result;
     }
 
@@ -2969,8 +2969,8 @@ public class Request implements HttpServletRequest {
         if (!create) {
             return null;
         }
-        boolean trackModesIncludesCookie = context.getServletContext().getEffectiveSessionTrackingModes()
-                .contains(SessionTrackingMode.COOKIE);
+        boolean trackModesIncludesCookie =
+                context.getServletContext().getEffectiveSessionTrackingModes().contains(SessionTrackingMode.COOKIE);
         if (trackModesIncludesCookie && response.getResponse().isCommitted()) {
             throw new IllegalStateException(sm.getString("coyoteRequest.sessionCreateCommitted"));
         }
@@ -3018,8 +3018,8 @@ public class Request implements HttpServletRequest {
 
         // Creating a new session cookie based on that session
         if (session != null && trackModesIncludesCookie) {
-            Cookie cookie = ApplicationSessionCookieConfig.createSessionCookie(context, session.getIdInternal(),
-                    isSecure());
+            Cookie cookie =
+                    ApplicationSessionCookieConfig.createSessionCookie(context, session.getIdInternal(), isSecure());
 
             response.addSessionCookieInternal(cookie);
         }
@@ -3339,7 +3339,7 @@ public class Request implements HttpServletRequest {
         // a local collection, sorted by the quality value (so we can
         // add Locales in descending order). The values will be ArrayLists
         // containing the corresponding Locales to be added
-        TreeMap<Double, ArrayList<Locale>> locales = new TreeMap<>();
+        TreeMap<Double,ArrayList<Locale>> locales = new TreeMap<>();
 
         Enumeration<String> values = getHeaders("accept-language");
 
@@ -3364,7 +3364,7 @@ public class Request implements HttpServletRequest {
      * @param value   the header value
      * @param locales the map that will hold the result
      */
-    protected void parseLocalesHeader(String value, TreeMap<Double, ArrayList<Locale>> locales) {
+    protected void parseLocalesHeader(String value, TreeMap<Double,ArrayList<Locale>> locales) {
 
         List<AcceptLanguage> acceptLanguages;
         try {
@@ -3394,14 +3394,14 @@ public class Request implements HttpServletRequest {
         // void remove(Request request, String name);
     }
 
-    private static final Map<String, SpecialAttributeAdapter> specialAttributes = new HashMap<>();
+    private static final Map<String,SpecialAttributeAdapter> specialAttributes = new HashMap<>();
 
     static {
         specialAttributes.put(Globals.DISPATCHER_TYPE_ATTR, new SpecialAttributeAdapter() {
             @Override
             public Object get(Request request, String name) {
-                return (request.internalDispatcherType == null) ? DispatcherType.REQUEST
-                        : request.internalDispatcherType;
+                return (request.internalDispatcherType == null) ? DispatcherType.REQUEST :
+                        request.internalDispatcherType;
             }
 
             @Override
@@ -3412,8 +3412,8 @@ public class Request implements HttpServletRequest {
         specialAttributes.put(Globals.DISPATCHER_REQUEST_PATH_ATTR, new SpecialAttributeAdapter() {
             @Override
             public Object get(Request request, String name) {
-                return (request.requestDispatcherPath == null) ? request.getRequestPathMB().toString()
-                        : request.requestDispatcherPath.toString();
+                return (request.requestDispatcherPath == null) ? request.getRequestPathMB().toString() :
+                        request.requestDispatcherPath.toString();
             }
 
             @Override
diff --git a/java/org/apache/catalina/connector/RequestFacade.java b/java/org/apache/catalina/connector/RequestFacade.java
index bdd85586bf..44544a431f 100644
--- a/java/org/apache/catalina/connector/RequestFacade.java
+++ b/java/org/apache/catalina/connector/RequestFacade.java
@@ -65,10 +65,10 @@ public class RequestFacade implements HttpServletRequest {
     }
 
 
-    private final class GetParameterMapPrivilegedAction implements PrivilegedAction<Map<String, String[]>> {
+    private final class GetParameterMapPrivilegedAction implements PrivilegedAction<Map<String,String[]>> {
 
         @Override
-        public Map<String, String[]> run() {
+        public Map<String,String[]> run() {
             return request.getParameterMap();
         }
     }
@@ -347,7 +347,7 @@ public class RequestFacade implements HttpServletRequest {
 
 
     @Override
-    public Map<String, String[]> getParameterMap() {
+    public Map<String,String[]> getParameterMap() {
         checkFacade();
 
         if (Globals.IS_SECURITY_ENABLED) {
@@ -846,7 +846,7 @@ public class RequestFacade implements HttpServletRequest {
 
 
     @Override
-    public Map<String, String> getTrailerFields() {
+    public Map<String,String> getTrailerFields() {
         checkFacade();
         return request.getTrailerFields();
     }
diff --git a/java/org/apache/catalina/connector/Response.java b/java/org/apache/catalina/connector/Response.java
index 57de133eb8..eea0919c8d 100644
--- a/java/org/apache/catalina/connector/Response.java
+++ b/java/org/apache/catalina/connector/Response.java
@@ -1107,13 +1107,13 @@ public class Response implements HttpServletResponse {
 
 
     @Override
-    public void setTrailerFields(Supplier<Map<String, String>> supplier) {
+    public void setTrailerFields(Supplier<Map<String,String>> supplier) {
         getCoyoteResponse().setTrailerFields(supplier);
     }
 
 
     @Override
-    public Supplier<Map<String, String>> getTrailerFields() {
+    public Supplier<Map<String,String>> getTrailerFields() {
         return getCoyoteResponse().getTrailerFields();
     }
 
@@ -1518,8 +1518,8 @@ public class Response implements HttpServletResponse {
         }
 
         if (SecurityUtil.isPackageProtectionEnabled()) {
-            Boolean result = AccessController
-                    .doPrivileged(new PrivilegedDoIsEncodable(getContext(), hreq, session, location));
+            Boolean result =
+                    AccessController.doPrivileged(new PrivilegedDoIsEncodable(getContext(), hreq, session, location));
             return result.booleanValue();
         } else {
             return doIsEncodeable(getContext(), hreq, session, location);
diff --git a/java/org/apache/catalina/connector/ResponseFacade.java b/java/org/apache/catalina/connector/ResponseFacade.java
index 9fc4fe852d..5965979f56 100644
--- a/java/org/apache/catalina/connector/ResponseFacade.java
+++ b/java/org/apache/catalina/connector/ResponseFacade.java
@@ -504,14 +504,14 @@ public class ResponseFacade implements HttpServletResponse {
 
 
     @Override
-    public void setTrailerFields(Supplier<Map<String, String>> supplier) {
+    public void setTrailerFields(Supplier<Map<String,String>> supplier) {
         checkFacade();
         response.setTrailerFields(supplier);
     }
 
 
     @Override
-    public Supplier<Map<String, String>> getTrailerFields() {
+    public Supplier<Map<String,String>> getTrailerFields() {
         checkFacade();
         return response.getTrailerFields();
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org