You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/31 09:20:53 UTC
[GitHub] [phoenix] richardantal opened a new pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …
richardantal opened a new pull request #1242:
URL: https://github.com/apache/phoenix/pull/1242
…it in sqlline.py
Change-Id: Ifd31e25b303ab3d2872b53f4a503219539777544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] richardantal commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #1242:
URL: https://github.com/apache/phoenix/pull/1242#issuecomment-855976665
Built it locally and run a smoke test with sqlline.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1242:
URL: https://github.com/apache/phoenix/pull/1242#issuecomment-851642088
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 25s | 4.x passed |
| +1 :green_heart: | compile | 2m 4s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 50s | 4.x passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 8m 5s | root in the patch failed. |
| -1 :x: | compile | 1m 57s | root in the patch failed. |
| -1 :x: | javac | 1m 57s | root in the patch failed. |
| -1 :x: | pylint | 0m 11s | The patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 10s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 1m 29s | root in the patch failed. |
| -1 :x: | javadoc | 0m 11s | phoenix-assembly in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 171m 46s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
| | | 207m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1242 |
| Optional Tests | dupname asflicense pylint javac javadoc unit xml compile |
| uname | Linux dd69f7c82397 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / d0c5627 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/testReport/ |
| Max. process+thread count | 5871 (vs. ulimit of 30000) |
| modules | C: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/console |
| versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1242:
URL: https://github.com/apache/phoenix/pull/1242#issuecomment-851464632
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 52s | 4.x passed |
| +1 :green_heart: | compile | 2m 4s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 59s | 4.x passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 7m 29s | root in the patch failed. |
| -1 :x: | compile | 2m 6s | root in the patch failed. |
| -1 :x: | javac | 2m 6s | root in the patch failed. |
| -1 :x: | pylint | 0m 11s | The patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 10s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 1m 36s | root in the patch failed. |
| -1 :x: | javadoc | 0m 12s | phoenix-assembly in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 161m 1s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 200m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1242 |
| Optional Tests | dupname asflicense pylint javac javadoc unit xml compile |
| uname | Linux 6c8f872f3f2f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / d0c5627 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/testReport/ |
| Max. process+thread count | 5503 (vs. ulimit of 30000) |
| modules | C: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/console |
| versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] richardantal merged pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …
Posted by GitBox <gi...@apache.org>.
richardantal merged pull request #1242:
URL: https://github.com/apache/phoenix/pull/1242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1242:
URL: https://github.com/apache/phoenix/pull/1242#issuecomment-851568240
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 17s | 4.x passed |
| +1 :green_heart: | compile | 1m 32s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 31s | 4.x passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 5m 36s | root in the patch failed. |
| -1 :x: | compile | 1m 27s | root in the patch failed. |
| -1 :x: | javac | 1m 27s | root in the patch failed. |
| -1 :x: | pylint | 0m 8s | The patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 1m 10s | root in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix-assembly in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 153m 16s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. |
| | | 182m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1242 |
| Optional Tests | dupname asflicense pylint javac javadoc unit xml compile |
| uname | Linux cf582dff551e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / d0c5627 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/testReport/ |
| Max. process+thread count | 5683 (vs. ulimit of 30000) |
| modules | C: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/console |
| versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org