You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2014/10/07 21:34:52 UTC
Review Request 26423: Added documentation for egress rate limit
control
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
docs/network-monitoring.md 2a85f8b
Diff: https://reviews.apache.org/r/26423/diff/
Testing
-------
not needed.
Thanks,
Chi Zhang
Re: Review Request 26423: Added documentation for egress rate limit
control
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/#review58152
-----------------------------------------------------------
docs/network-monitoring.md
<https://reviews.apache.org/r/26423/#comment99070>
Can "the previous section" be a link?
- Dominic Hamon
On Oct. 7, 2014, 12:34 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26423/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 12:34 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md 2a85f8b
>
> Diff: https://reviews.apache.org/r/26423/diff/
>
>
> Testing
> -------
>
> not needed.
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 26423: Added documentation for egress rate limit
control
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/#review58153
-----------------------------------------------------------
Ship it!
docs/network-monitoring.md
<https://reviews.apache.org/r/26423/#comment99072>
s/mesos/Mesos/
s/With the use of it, .../With this feature enabled, each containers' egress is rate limited to the specified limit./
s/This could potentially .../This can prevent a single container from dominating the network link/
docs/network-monitoring.md
<https://reviews.apache.org/r/26423/#comment99073>
s/fully depends on/requires/
- Ian Downes
On Oct. 7, 2014, 12:34 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26423/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 12:34 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md 2a85f8b
>
> Diff: https://reviews.apache.org/r/26423/diff/
>
>
> Testing
> -------
>
> not needed.
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 26423: Added documentation for egress rate limit
control
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/#review58250
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26423]
All tests passed.
- Mesos ReviewBot
On Oct. 23, 2014, 11:53 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26423/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 11:53 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md 2a85f8b
>
> Diff: https://reviews.apache.org/r/26423/diff/
>
>
> Testing
> -------
>
> not needed.
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 26423: Added documentation for egress rate limit
control
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 11:53 p.m.)
Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
addressed comments.
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
docs/network-monitoring.md 2a85f8b
Diff: https://reviews.apache.org/r/26423/diff/
Testing
-------
not needed.
Thanks,
Chi Zhang
Re: Review Request 26423: Added documentation for egress rate limit
control
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26423/#review55728
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26423]
All tests passed.
- Mesos ReviewBot
On Oct. 7, 2014, 7:34 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26423/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 7:34 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md 2a85f8b
>
> Diff: https://reviews.apache.org/r/26423/diff/
>
>
> Testing
> -------
>
> not needed.
>
>
> Thanks,
>
> Chi Zhang
>
>