You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Igor Belakovskiy (JIRA)" <ji...@apache.org> on 2011/07/22 17:25:57 UTC
[jira] [Created] (SHINDIG-1559) Trailer comma in
features/opensearch/opensearch.js
Trailer comma in features/opensearch/opensearch.js
--------------------------------------------------
Key: SHINDIG-1559
URL: https://issues.apache.org/jira/browse/SHINDIG-1559
Project: Shindig
Issue Type: Bug
Components: Javascript
Affects Versions: 2.0.3
Reporter: Igor Belakovskiy
Priority: Minor
Fix For: 2.0.3
Attachments: osclosure.txt
trailing comma in the js file that would cause an error in IE
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1559) Trailer comma in
features/opensearch/opensearch.js
Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Belakovskiy updated SHINDIG-1559:
--------------------------------------
Attachment: osclosure.txt
patch for the fix.
> Trailer comma in features/opensearch/opensearch.js
> --------------------------------------------------
>
> Key: SHINDIG-1559
> URL: https://issues.apache.org/jira/browse/SHINDIG-1559
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.3
> Reporter: Igor Belakovskiy
> Priority: Minor
> Labels: patch
> Fix For: 2.0.3
>
> Attachments: osclosure.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> trailing comma in the js file that would cause an error in IE
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1559) Trailer comma in
features/opensearch/opensearch.js
Posted by "Eric Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069591#comment-13069591 ]
Eric Woods commented on SHINDIG-1559:
-------------------------------------
Nevermind. There is a unit test below that is uncommented for testing, making the comma necessary. Patch applied, thanks Igor.
> Trailer comma in features/opensearch/opensearch.js
> --------------------------------------------------
>
> Key: SHINDIG-1559
> URL: https://issues.apache.org/jira/browse/SHINDIG-1559
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.3
> Reporter: Igor Belakovskiy
> Priority: Minor
> Labels: patch
> Fix For: 2.0.3
>
> Attachments: osclosure.txt, osclosure.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> trailing comma in the js file that would cause an error in IE
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1559) Trailer comma in
features/opensearch/opensearch.js
Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Belakovskiy updated SHINDIG-1559:
--------------------------------------
Attachment: osclosure.txt
Updated patch with Eric's suggestion
> Trailer comma in features/opensearch/opensearch.js
> --------------------------------------------------
>
> Key: SHINDIG-1559
> URL: https://issues.apache.org/jira/browse/SHINDIG-1559
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.3
> Reporter: Igor Belakovskiy
> Priority: Minor
> Labels: patch
> Fix For: 2.0.3
>
> Attachments: osclosure.txt, osclosure.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> trailing comma in the js file that would cause an error in IE
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1559) Trailer comma in
features/opensearch/opensearch.js
Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069588#comment-13069588 ]
Igor Belakovskiy commented on SHINDIG-1559:
-------------------------------------------
good point, adding updated patch.
> Trailer comma in features/opensearch/opensearch.js
> --------------------------------------------------
>
> Key: SHINDIG-1559
> URL: https://issues.apache.org/jira/browse/SHINDIG-1559
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.3
> Reporter: Igor Belakovskiy
> Priority: Minor
> Labels: patch
> Fix For: 2.0.3
>
> Attachments: osclosure.txt, osclosure.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> trailing comma in the js file that would cause an error in IE
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1559) Trailer comma in
features/opensearch/opensearch.js
Posted by "Eric Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069585#comment-13069585 ]
Eric Woods commented on SHINDIG-1559:
-------------------------------------
Igor - why comment the comma out and not simply remove it? Seems we'd want to remove unused or unnecessary code to keep things clean.
> Trailer comma in features/opensearch/opensearch.js
> --------------------------------------------------
>
> Key: SHINDIG-1559
> URL: https://issues.apache.org/jira/browse/SHINDIG-1559
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.3
> Reporter: Igor Belakovskiy
> Priority: Minor
> Labels: patch
> Fix For: 2.0.3
>
> Attachments: osclosure.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> trailing comma in the js file that would cause an error in IE
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira