You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2017/12/13 09:38:51 UTC
[GitHub] carbondata pull request #1651: [CARBONDATA-1891] Fixed timeseries table crea...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1651
[CARBONDATA-1891] Fixed timeseries table creation after data load
**Analysis:** CreatePreAggregateTableCommand.run() was being called from CarbonCreateDataMapCommand.processMetaData() Due to this wrong table was being created which is not in DataMapSchemaList.
**Solution:** Refactor code to call CreatePreAggregateTableCommand.processMetadata instead of run.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata timeseries_create_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1651
----
commit 6ce8efc9f7afbf27a36ac4d1e959ebaf51545d34
Author: kunal642 <ku...@gmail.com>
Date: 2017-12-13T09:25:09Z
fixed issue in which create table was getting fired multiple times which led to None.get exception
----
---
[GitHub] carbondata pull request #1651: [CARBONDATA-1891] Fixed timeseries table crea...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1651#discussion_r156611792
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -514,9 +514,16 @@ object PreAggregateUtil {
CarbonCommonConstants.VALIDATE_CARBON_INPUT_SEGMENTS +
parentCarbonTable.getDatabaseName + "." +
parentCarbonTable.getTableName, validateSegments.toString)
- val headers = parentCarbonTable.getTableInfo.getDataMapSchemaList.asScala.
- find(_.getChildSchema.getTableName.equals(dataMapIdentifier.table)).get.getChildSchema.
- getListOfColumns.asScala.map(_.getColumnName).mkString(",")
+ val dataMapSchemas = parentCarbonTable.getTableInfo.getDataMapSchemaList.asScala
+ val headers = dataMapSchemas.find(_.getChildSchema.getTableName.equalsIgnoreCase(
+ dataMapIdentifier.table)) match {
+ case Some(dataMapSchema) =>
+ dataMapSchema.getChildSchema.getListOfColumns.asScala.map(_.getColumnName).mkString(",")
+ case None =>
--- End diff --
This is just to throw a proper exception if ever this condition is met. The message will tell which aggregate table is not present in the datamap schema list.
---
[GitHub] carbondata issue #1651: [CARBONDATA-1891] Fixed timeseries table creation af...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1651
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/693/
---
[GitHub] carbondata issue #1651: [CARBONDATA-1891] Fixed timeseries table creation af...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1651
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1922/
---
[GitHub] carbondata pull request #1651: [CARBONDATA-1891] Fixed timeseries table crea...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1651#discussion_r156607909
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -514,9 +514,16 @@ object PreAggregateUtil {
CarbonCommonConstants.VALIDATE_CARBON_INPUT_SEGMENTS +
parentCarbonTable.getDatabaseName + "." +
parentCarbonTable.getTableName, validateSegments.toString)
- val headers = parentCarbonTable.getTableInfo.getDataMapSchemaList.asScala.
- find(_.getChildSchema.getTableName.equals(dataMapIdentifier.table)).get.getChildSchema.
- getListOfColumns.asScala.map(_.getColumnName).mkString(",")
+ val dataMapSchemas = parentCarbonTable.getTableInfo.getDataMapSchemaList.asScala
+ val headers = dataMapSchemas.find(_.getChildSchema.getTableName.equalsIgnoreCase(
+ dataMapIdentifier.table)) match {
+ case Some(dataMapSchema) =>
+ dataMapSchema.getChildSchema.getListOfColumns.asScala.map(_.getColumnName).mkString(",")
+ case None =>
--- End diff --
when this condition will come??
---
[GitHub] carbondata issue #1651: [CARBONDATA-1891] Fixed timeseries table creation af...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1651
LGTM
---
[GitHub] carbondata pull request #1651: [CARBONDATA-1891] Fixed timeseries table crea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1651
---
[GitHub] carbondata issue #1651: [CARBONDATA-1891] Fixed timeseries table creation af...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1651
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2253/
---