You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 04:36:37 UTC
[GitHub] [airflow] YuDorogov opened a new pull request #15561: Fix KEDA Autoscaler connectionFromEnv
YuDorogov opened a new pull request #15561:
URL: https://github.com/apache/airflow/pull/15561
Set worker container first in containers, move git-sync container to bottom, beacuse KEDA get environment variables(AIRFLOW_CONN_AIRFLOW_DB) from worker container(git-sync container not contain this env variable)
If i use git-sync sidecar container with keda autoscaler, git-sync will be [0] in containers array, and not contain connection env's, then KEDA could not get AIRFLOW_CONN_AIRFLOW_DB variable from git-sync sidecar in worker deployment(git-sync not contain it).
Resolution: the worker container must always be [0] in the container array, because it contain all connection env's, git-sync moves to [1]
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #15561: Fix KEDA Autoscaler connectionFromEnv
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #15561:
URL: https://github.com/apache/airflow/pull/15561#issuecomment-828566687
Ah ok, found it here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15561: Fix KEDA Autoscaler connectionFromEnv
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15561:
URL: https://github.com/apache/airflow/pull/15561#issuecomment-828708479
Helm Chart Unit test is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15561: Fix KEDA Autoscaler connectionFromEnv
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15561:
URL: https://github.com/apache/airflow/pull/15561#issuecomment-828573109
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15561: Fix KEDA Autoscaler connectionFromEnv
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15561:
URL: https://github.com/apache/airflow/pull/15561#issuecomment-829686358
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15561: Fix KEDA Autoscaler connectionFromEnv
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15561:
URL: https://github.com/apache/airflow/pull/15561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org