You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kibble.apache.org by tu...@apache.org on 2020/12/13 12:33:07 UTC

[kibble] branch main updated: Fix failing test & Run tests on CI (#115)

This is an automated email from the ASF dual-hosted git repository.

turbaszek pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/kibble.git


The following commit(s) were added to refs/heads/main by this push:
     new 89748e4  Fix failing test & Run tests on CI (#115)
89748e4 is described below

commit 89748e42e611842babff57199ed82b4b8175f2c6
Author: Kaxil Naik <ka...@gmail.com>
AuthorDate: Sun Dec 13 12:32:56 2020 +0000

    Fix failing test & Run tests on CI (#115)
    
    This PR adds Github Action job to run tests on CI & fix a failing test
---
 .github/workflows/ci.yaml   | 10 ++++++++++
 tests/test_configuration.py |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index fc571d8..602c41e 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -39,3 +39,13 @@ jobs:
         run: docker run apache/kibble kibble --help
       - name: Check dependencies
         run: docker run apache/kibble pip check
+  run-tests:
+    name: Run Tests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+        with:
+          python-version: '3.8'
+      - run: pip install '.[devel]'
+      - run: pytest tests
diff --git a/tests/test_configuration.py b/tests/test_configuration.py
index 32c13f1..74e8c03 100644
--- a/tests/test_configuration.py
+++ b/tests/test_configuration.py
@@ -28,7 +28,7 @@ class TestDefaultConfig:
             ("accounts", "verify", True),
             ("api", "database", 2),
             ("api", "version", "0.1.0"),
-            ("elasticsearch", "conn_uri", "elasticsearch:9200"),
+            ("elasticsearch", "conn_uri", "http://elasticsearch:9200"),
             ("mail", "mailhost", "localhost:25"),
         ],
     )