You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by he...@apache.org on 2006/09/16 12:33:57 UTC
svn commit: r446848 -
/jakarta/velocity/engine/trunk/src/java/org/apache/velocity/util/ExceptionUtils.java
Author: henning
Date: Sat Sep 16 03:33:57 2006
New Revision: 446848
URL: http://svn.apache.org/viewvc?view=rev&rev=446848
Log:
Explicitly rethrow RuntimeExceptions, don't eat them up silently. Suggested by FindBugs.
Modified:
jakarta/velocity/engine/trunk/src/java/org/apache/velocity/util/ExceptionUtils.java
Modified: jakarta/velocity/engine/trunk/src/java/org/apache/velocity/util/ExceptionUtils.java
URL: http://svn.apache.org/viewvc/jakarta/velocity/engine/trunk/src/java/org/apache/velocity/util/ExceptionUtils.java?view=diff&rev=446848&r1=446847&r2=446848
==============================================================================
--- jakarta/velocity/engine/trunk/src/java/org/apache/velocity/util/ExceptionUtils.java (original)
+++ jakarta/velocity/engine/trunk/src/java/org/apache/velocity/util/ExceptionUtils.java Sat Sep 16 03:33:57 2006
@@ -56,6 +56,10 @@
re = (Throwable) constructor
.newInstance(new Object[]{message, cause});
}
+ catch (RuntimeException e)
+ {
+ throw e;
+ }
catch (Exception e)
{
causesAllowed = false;
@@ -71,6 +75,10 @@
.newInstance(new Object[]{message
+ " caused by " + cause});
}
+ catch (RuntimeException e)
+ {
+ throw e;
+ }
catch (Exception e)
{
throw new RuntimeException("Error caused " + e); // should be impossible
@@ -90,6 +98,10 @@
{
Method method = onObject.getClass().getMethod("initCause", new Class[]{Throwable.class});
method.invoke(onObject, new Object[]{cause});
+ }
+ catch (RuntimeException e)
+ {
+ throw e;
}
catch (Exception e)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org