[GitHub] [spark] xinrong-databricks commented on a change in pull request #35533: [SPARK-38225][SQL] Adjust input `format` of function `to_binary`

[GitBox <gi...@apache.org>]

xinrong-databricks commented on a change in pull request #35533:
URL: https://github.com/apache/spark/pull/35533#discussion_r808784101



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2565,15 +2565,14 @@ case class ToBinary(expr: Expression, format: Option[Expression], child: Express
       case lit if lit.foldable =>

Review comment:
       Makes sense.
   
   May I confirm that the case below is acceptable?
   ```
   spark-sql> select to_binary(cast(null as int), 'utf-8');
   NULL
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org