You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/26 08:59:05 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
HyukjinKwon opened a new pull request #31660:
URL: https://github.com/apache/spark/pull/31660
### What changes were proposed in this pull request?
This PR proposes to make the scripts working by:
- Recovering credit related scripts that were broken from https://github.com/apache/spark/pull/29563
`raw_input` does not exist in `releaseutils` but only in Python 2
- Dropping Python 2 in these scripts because we dropped Python 2 in https://github.com/apache/spark/pull/28957
- Making these scripts workin with Python 3
### Why are the changes needed?
To unblock the release.
### Does this PR introduce _any_ user-facing change?
No, it's dev-only change.
### How was this patch tested?
I manually tested against Spark 3.1.1 RC3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786513367
Thanks guys. I just made a simple cleanup. I will merge this once linters pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786619829
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135502/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786617408
**[Test build #135502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135502/testReport)** for PR 31660 at commit [`6b510a0`](https://github.com/apache/spark/commit/6b510a05e2f83f2c10cfaafd6427e7377c8fb0ae).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31660:
URL: https://github.com/apache/spark/pull/31660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786538953
**[Test build #135502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135502/testReport)** for PR 31660 at commit [`6b510a0`](https://github.com/apache/spark/commit/6b510a05e2f83f2c10cfaafd6427e7377c8fb0ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786591587
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40083/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786538953
**[Test build #135502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135502/testReport)** for PR 31660 at commit [`6b510a0`](https://github.com/apache/spark/commit/6b510a05e2f83f2c10cfaafd6427e7377c8fb0ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786585958
Merged to master and branch-3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786591587
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40083/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31660:
URL: https://github.com/apache/spark/pull/31660#discussion_r583494569
##########
File path: dev/create-release/translate-contributors.py
##########
@@ -32,14 +32,7 @@
import sys
from releaseutils import JIRA, JIRAError, get_jira_name, Github, get_github_name, \
- contributors_file_name, is_valid_author, raw_input, capitalize_author, yesOrNoPrompt
-
-try:
- import unidecode
-except ImportError:
- print("This tool requires the unidecode library to decode obscure github usernames")
Review comment:
Just to clarify, I think now most of release docs, notes, and everywhere else can handle UFT-8 properly, and we don't have to force and mangle other people's name into ASCII. I believe this was initially introduced due to unicode and Python 2's string handling. If there's an issue, we believe we should try to fix it instead of manipulating author's names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31660: [SPARK-34551][INFRA] Fix credit related scripts to recover, drop Python 2 and work with Python 3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31660:
URL: https://github.com/apache/spark/pull/31660#issuecomment-786619829
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135502/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org