You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2012/10/29 14:56:37 UTC
svn commit: r1403297 -
/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
Author: ggregory
Date: Mon Oct 29 13:56:37 2012
New Revision: 1403297
URL: http://svn.apache.org/viewvc?rev=1403297&view=rev
Log:
Checkstyle: Method length is 199 lines (max allowed is 150). Refactor ProxyHTTP instantiation.
Modified:
commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
Modified: commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java?rev=1403297&r1=1403296&r2=1403297&view=diff
==============================================================================
--- commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java (original)
+++ commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java Mon Oct 29 13:56:37 2012
@@ -205,14 +205,7 @@ public final class SftpClientFactory
Proxy proxy = null;
if (SftpFileSystemConfigBuilder.PROXY_HTTP.equals(proxyType))
{
- if (proxyPort != 0)
- {
- proxy = new ProxyHTTP(proxyHost, proxyPort);
- }
- else
- {
- proxy = new ProxyHTTP(proxyHost);
- }
+ proxy = proxyPort == 0 ? new ProxyHTTP(proxyHost) : new ProxyHTTP(proxyHost, proxyPort);
}
else if (SftpFileSystemConfigBuilder.PROXY_SOCKS5.equals(proxyType))
{