You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 12:48:19 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

tillrohrmann opened a new pull request #12248:
URL: https://github.com/apache/flink/pull/12248


   ## What is the purpose of the change
   
   In order to harden the test case FileUploadHandlerTest, this commit disables the timeouts
   of the used OkHttpClient.
   
   cc @rmetzger 
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

tillrohrmann commented on pull request #12248:
URL: https://github.com/apache/flink/pull/12248#issuecomment-631351576


   Thanks for the review @rmetzger and @zentol. I've addressed your comments. Merging this PR now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

tillrohrmann closed pull request #12248:
URL: https://github.com/apache/flink/pull/12248


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12248:
URL: https://github.com/apache/flink/pull/12248#issuecomment-630795516

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ae0b32c79fb85e36132f4bd64a6721215781cf8c (Tue May 19 12:50:30 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

zentol commented on a change in pull request #12248:
URL: https://github.com/apache/flink/pull/12248#discussion_r427432577



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java
##########
@@ -256,6 +257,14 @@ public void testUploadCleanupOnFailure() throws IOException {
 		verifyNoFileIsRegisteredToDeleteOnExitHook();
 	}
 
+	private OkHttpClient createOkHttpClientWithNoTimeouts() {
+		return new OkHttpClient().newBuilder()

Review comment:
       maybe use `new OkHttpClient.Builder()...`, it's a bit odd that we are creating 2 clients?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12248:
URL: https://github.com/apache/flink/pull/12248#issuecomment-630803440


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ae0b32c79fb85e36132f4bd64a6721215781cf8c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1853",
       "triggerID" : "ae0b32c79fb85e36132f4bd64a6721215781cf8c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ae0b32c79fb85e36132f4bd64a6721215781cf8c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1853) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

tillrohrmann commented on a change in pull request #12248:
URL: https://github.com/apache/flink/pull/12248#discussion_r427860290



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java
##########
@@ -256,6 +257,14 @@ public void testUploadCleanupOnFailure() throws IOException {
 		verifyNoFileIsRegisteredToDeleteOnExitHook();
 	}
 
+	private OkHttpClient createOkHttpClientWithNoTimeouts() {
+		return new OkHttpClient().newBuilder()

Review comment:
       True. Will update the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12248:
URL: https://github.com/apache/flink/pull/12248#issuecomment-630803440


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ae0b32c79fb85e36132f4bd64a6721215781cf8c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1853",
       "triggerID" : "ae0b32c79fb85e36132f4bd64a6721215781cf8c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ae0b32c79fb85e36132f4bd64a6721215781cf8c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1853) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12248:
URL: https://github.com/apache/flink/pull/12248#issuecomment-630795516

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 9a741f5a028b1de3daaa4a88245a63a02b5864ab (Fri Oct 16 10:51:45 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12248: [FLINK-17725][tests] Disable OkHttpClient timeouts for FileUploadHandlerTest

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12248:
URL: https://github.com/apache/flink/pull/12248#issuecomment-630803440


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ae0b32c79fb85e36132f4bd64a6721215781cf8c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ae0b32c79fb85e36132f4bd64a6721215781cf8c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ae0b32c79fb85e36132f4bd64a6721215781cf8c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org