You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tadeja (via GitHub)" <gi...@apache.org> on 2026/04/07 14:55:53 UTC
[PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]
tadeja opened a new pull request, #49682:
URL: https://github.com/apache/arrow/pull/49682
### Rationale for this change
Fixes #49586
`std::multimap::extract(key)` does not guarantee returning the first element when there are duplicate keys.
### What changes are included in this PR?
Replace extract(key) with lower_bound(key) plus erase(iterator). `lower_bound` guarantees first matching element, then read `it->second` and then `erase` the node (`extract` is not needed as the node isn't reused here).
### Are these changes tested?
Yes, CI jobs are passing.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49682:
URL: https://github.com/apache/arrow/pull/49682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #49682:
URL: https://github.com/apache/arrow/pull/49682#issuecomment-4201150524
Thanks for the fix.
Switching from `std::multimap::extract(key)` to `lower_bound(key)` + `erase(iterator)` is the right change here. It makes duplicate-field selection deterministic (first matching field) and matches the expected behavior covered by the existing `StructToStructSubset` duplicate-name tests.
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49682:
URL: https://github.com/apache/arrow/pull/49682#issuecomment-4203884738
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 35fb62e6224617d5ae749533654e9f8c7a6250c7.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/70366173367) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49682:
URL: https://github.com/apache/arrow/pull/49682#issuecomment-4199934732
:warning: GitHub issue #49586 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]
Posted by "tadeja (via GitHub)" <gi...@apache.org>.
tadeja commented on PR #49682:
URL: https://github.com/apache/arrow/pull/49682#issuecomment-4200582240
@pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org