You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/08/15 02:11:34 UTC
[jclouds] Enforce a non-negative content length (#116)
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds content-length-non-negative
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/116
-- Commit Summary --
* Enforce a non-negative content length
-- File Changes --
M blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java (1)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/116.patch
https://github.com/jclouds/jclouds/pull/116.diff
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #144](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/144/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-22679098
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #314](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/314/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-22678886
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by Andrew Gaul <no...@github.com>.
@tdmanv Does this commit prevent the symptoms you saw?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-22677197
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by Andrew Gaul <no...@github.com>.
Closed #116.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by Thomas Manville <no...@github.com>.
Yes, it should. Thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-22677647
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master(https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=commit;h=d387a251132e7d80a9ea07c6c62decb70af7c490). Guessing this should also be applied to 1.6.x when the 1.6.2-incubating release is done?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-23305270
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #602](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/602/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-22679086
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by Andrew Gaul <no...@github.com>.
Let's skip this for 1.6.x since it is unlikely people will hit it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-23305338
Re: [jclouds] Enforce a non-negative content length (#116)
Posted by Andrew Phillips <no...@github.com>.
+1. Looks like we don't require unit tests for these kind of checks, which makes sense to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/116#issuecomment-22686428