You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/23 06:22:48 UTC
[GitHub] [airflow] mik-laj opened a new pull request #8984: Fix references in docs
mik-laj opened a new pull request #8984:
URL: https://github.com/apache/airflow/pull/8984
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #8984: Fix references in docs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #8984:
URL: https://github.com/apache/airflow/pull/8984#discussion_r429529543
##########
File path: tests/test_impersonation.py
##########
@@ -50,8 +50,8 @@
def mock_custom_module_path(path: str):
"""
- This decorator adds a path to sys.path to simulate running the current script with the ``PYTHONPATH``
- environment variable set and sets the environment variable ``PYTHONPATH`` to change the
+ This decorator adds a path to sys.path to simulate running the current script with the :envvar:`PYTHONPATH`
+ environment variable set and sets the environment variable :envvar:`PYTHONPATH` to change the
Review comment:
```suggestion
This decorator adds a path to sys.path to simulate running the current script with the
:envvar:`PYTHONPATH` environment variable set and sets the environment variable
:envvar:`PYTHONPATH` to change the
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #8984: Fix references in docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8984:
URL: https://github.com/apache/airflow/pull/8984#issuecomment-633009862
All good but one line too long in the impersonation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #8984: Fix references in docs
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #8984:
URL: https://github.com/apache/airflow/pull/8984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org