[GitHub] michellethomas opened a new pull request #5021: Allow MetricsControl to aggregate on a column with an expression

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #5021: Allow MetricsControl to aggregate on a column with an expression
URL: https://github.com/apache/incubator-superset/pull/5021
 
 
   In the new MetricsControl, selecting a column with an expression would fail because it's just using the column name which doesn't exist in the underlying table (only in our metadata). This would add the expression (if there is one) inside the aggregation.
   
   @john-bodley @GabeLoins @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org