You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2011/05/13 11:13:49 UTC
svn commit: r1102619 - /subversion/trunk/subversion/libsvn_client/externals.c
Author: rhuijben
Date: Fri May 13 09:13:49 2011
New Revision: 1102619
URL: http://svn.apache.org/viewvc?rev=1102619&view=rev
Log:
* subversion/libsvn_client/externals.c
(handle_external_item_change_wrapper): Following up on r1102502, revert
accidental change by temporary turning the code off in maintainer builds.
Modified:
subversion/trunk/subversion/libsvn_client/externals.c
Modified: subversion/trunk/subversion/libsvn_client/externals.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/externals.c?rev=1102619&r1=1102618&r2=1102619&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/externals.c (original)
+++ subversion/trunk/subversion/libsvn_client/externals.c Fri May 13 09:13:49 2011
@@ -1019,7 +1019,11 @@ handle_external_item_change_wrapper(cons
target_abspath,
old_item, new_item, scratch_pool);
- /*if (err && err->apr_err != SVN_ERR_CANCELLED)
+ /* ### This #ifndef should probably be removed once the externals handling
+ has stabilized, but currently it catches some errors in the test suite
+ that are ignored if this code is enabled */
+#ifndef SVN_DEBUG
+ if (err && err->apr_err != SVN_ERR_CANCELLED)
{
if (ib->ctx->notify_func2)
{
@@ -1033,7 +1037,8 @@ handle_external_item_change_wrapper(cons
}
svn_error_clear(err);
return SVN_NO_ERROR;
- }*/
+ }
+#endif
return svn_error_return(err);
}
RE: svn commit: r1102619 - /subversion/trunk/subversion/libsvn_client/externals.c
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: zaterdag 14 mei 2011 7:00
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1102619 -
> /subversion/trunk/subversion/libsvn_client/externals.c
>
> On Fri, May 13, 2011 at 05:13, <rh...@apache.org> wrote:
> > Author: rhuijben
> > Date: Fri May 13 09:13:49 2011
> > New Revision: 1102619
> >
> > URL: http://svn.apache.org/viewvc?rev=1102619&view=rev
> > Log:
> > * subversion/libsvn_client/externals.c
> > (handle_external_item_change_wrapper): Following up on r1102502,
> revert
> > accidental change by temporary turning the code off in maintainer
builds.
>
> Why would that be turned off for developers? It seems that we should
> be running code as close to production as possible. It seems a bit
> backwards: developers should be running *more* code (eg. assertions
> and other checks) rather than *less* code.
The code I temporarily disabled turns errors into warnings by sending them
to the notification handler. The regex based parsers in our test framework
then ignores these warnings and the test thinks the update was successful.
So disabling this code adds additional checks...
Bert
Re: svn commit: r1102619 - /subversion/trunk/subversion/libsvn_client/externals.c
Posted by Greg Stein <gs...@gmail.com>.
On Fri, May 13, 2011 at 05:13, <rh...@apache.org> wrote:
> Author: rhuijben
> Date: Fri May 13 09:13:49 2011
> New Revision: 1102619
>
> URL: http://svn.apache.org/viewvc?rev=1102619&view=rev
> Log:
> * subversion/libsvn_client/externals.c
> (handle_external_item_change_wrapper): Following up on r1102502, revert
> accidental change by temporary turning the code off in maintainer builds.
Why would that be turned off for developers? It seems that we should
be running code as close to production as possible. It seems a bit
backwards: developers should be running *more* code (eg. assertions
and other checks) rather than *less* code.
>...
Cheers,
-g