You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/07 08:36:07 UTC

[GitHub] [beam] thiagotnunes commented on a change in pull request #16844: [BEAM-12164]: allow for nanosecond precision

thiagotnunes commented on a change in pull request #16844:
URL: https://github.com/apache/beam/pull/16844#discussion_r820475968



##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -49,6 +49,10 @@ public void testGcpApiSurface() throws Exception {
             .pruningPattern("org[.]apache[.]beam[.].*Test.*")
             .pruningPattern("org[.]apache[.]beam[.].*IT")
             .pruningPattern("org[.]checkerframework[.].*[.]qual[.].*")
+            // Quick check packages, exposed only in testing

Review comment:
       We added a generator `TimestampGenerator` which is used in testing only. The generator needs to be public, otherwise we get a `IllegalAccessException` from quickcheck.
   
   Since these classes are used in test only, we thought is was ok to add them in exceptions here (like the `checkerframework` or other tests above)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org