You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "trxcllnt (via GitHub)" <gi...@apache.org> on 2023/09/11 23:10:20 UTC
[GitHub] [arrow] trxcllnt opened a new pull request, #37668: GH-37657: [JS] Run bin scripts with ts-node
trxcllnt opened a new pull request, #37668:
URL: https://github.com/apache/arrow/pull/37668
* update bin scripts to use ts-node in transpile-only mode
* remove ts-node config from top level `tsconfig.json`
* fix `tsc` errors in bin scripts
Fixes #37657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser closed pull request #37668: GH-37657: [JS] Run bin scripts with ts-node
URL: https://github.com/apache/arrow/pull/37668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1781715041
Benchmark runs are scheduled for commit 2ee36ead9f67e034ac6c73d752e5c74cb7d75e89. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "austin3dickey (via GitHub)" <gi...@apache.org>.
austin3dickey commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1783320084
I checked out this branch locally, rebased to `main`, and the JavaScript benchmarks work again. I don't think I have access to push to this fork, but that's a great sign! Thanks for the work so far.
If we don't merge this PR soon, I'm going to turn off the automatic benchmarking for JS since it's failing every time and covering up other errors like https://github.com/voltrondata-labs/arrow-benchmarks-ci/issues/166.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37668: GH-37657: [JS] Run bin scripts with ts-node
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1716715262
It seems that integration CI job failure is related to this: https://github.com/apache/arrow/actions/runs/6152750564/job/16695430388?pr=37668
Could you check the log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1758711447
@trxcllnt Could you rebase on main and resolve conflict?
@domoritz Could you review this again after that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1758875791
I'm happy to do another review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1783655315
I have rebased the PR locally favoring main for the yarn.lock conflicts. In the interest of getting the benchmarks going again I have opened an alternative PR #38500 (keeping authorship for @trxcllnt of course).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "austin3dickey (via GitHub)" <gi...@apache.org>.
austin3dickey commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1757706279
I just noticed that this open PR is expected to close https://github.com/apache/arrow/issues/37657. That's great news! Could someone please take another look to see if we can merge and turn the benchmarking jobs green again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1768716195
Hi, from my understanding benchmarks haven't been run for the last month or so for JS. It would be nice to re-enable them to validate we are not adding any performance issue on the Release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37668: GH-37657: [JS] Run bin scripts with ts-node
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1714707893
:warning: GitHub issue #37657 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1799209949
Yep, sorry I forgot to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1798929107
Should we close this PR as the other one has been merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "austin3dickey (via GitHub)" <gi...@apache.org>.
austin3dickey commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1781714874
@ursabot please benchmark lang=JavaScript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37657: [JS] Run bin scripts with ts-node [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37668:
URL: https://github.com/apache/arrow/pull/37668#issuecomment-1781790381
Thanks for your patience. Conbench analyzed the 0 benchmarking runs that have been run so far on PR commit 2ee36ead9f67e034ac6c73d752e5c74cb7d75e89.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/18097058181) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org