[jira] [Commented] (FLINK-10259) Key validation for GroupWindowAggregate is broken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601235#comment-16601235 ] 

ASF GitHub Bot commented on FLINK-10259:
----------------------------------------

hequn8128 commented on a change in pull request #6641: [FLINK-10259] Fix key extraction for GroupWindows.
URL: https://github.com/apache/flink/pull/6641#discussion_r214543996
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/InsertIntoITCase.scala
 ##########
 @@ -0,0 +1,406 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.stream.sql
+
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.streaming.api.TimeCharacteristic
+import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
+import org.apache.flink.table.api.scala._
+import org.apache.flink.table.api.{TableEnvironment, Types}
+import org.apache.flink.table.runtime.stream.table.{RowCollector, TestRetractSink, TestUpsertSink}
+import org.apache.flink.table.runtime.utils.StreamTestData
+import org.apache.flink.table.utils.MemoryTableSourceSinkUtil
+import org.apache.flink.test.util.{AbstractTestBase, TestBaseUtils}
+import org.junit.Assert._
+import org.junit.Test
+
+import scala.collection.JavaConverters._
+
+class InsertIntoITCase extends AbstractTestBase {
+
+  @Test
+  def testInsertIntoAppendStreamToTableSink(): Unit = {
 
 Review comment:
   Since we have this test case, should we remove the `testInsertIntoMemoryTable` in `SqlITCase` ? It seems the two test cases are same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Key validation for GroupWindowAggregate is broken
> -------------------------------------------------
>
>                 Key: FLINK-10259
>                 URL: https://issues.apache.org/jira/browse/FLINK-10259
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0, 1.5.4
>
>
> WindowGroups have multiple equivalent keys (start, end) that should be handled differently from other keys. The {{UpdatingPlanChecker}} uses equivalence groups to identify equivalent keys but the keys of WindowGroups are not correctly assigned to groups.
> This means that we cannot correctly extract keys from queries that use group windows.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)