[jira] Commented: (DIRSERVER-1059) Interceptor bypass logic is flawed

["Alex Karasulu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRSERVER-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530474 ] 

Alex Karasulu commented on DIRSERVER-1059:
------------------------------------------

I think I told you before but this is not a good idea because any kinds of interceptors can be added to the chain and dynamically.  So you cannot specify what is to be called for bypasses but what is to be bypassed.  Otherwise you will bypass interceptors that are added by other applications.  

You see what I mean?

> Interceptor bypass logic is flawed
> ----------------------------------
>
>                 Key: DIRSERVER-1059
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1059
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.2
>
>
> We currently have many places in the code where we are hard-coding the bypassed interceptor (ie, the interceptors which won't be called).
> I think this logic is flawed : as we can add new interceptors, those newly interceptors will be called, or the code where those bypasses are declared should be modified.
> Reverting the logic won't help : if we create a list of called interceptors instead of a list of bypassed interceptors, then we will still have to modify the code to add those new interceptors in the chain.
> Some other way to handle interceptors should be find to allow users to add new interceptors without any problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.