You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 07:23:29 UTC
[GitHub] [spark] sigmod opened a new pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
sigmod opened a new pull request #32290:
URL: https://github.com/apache/spark/pull/32290
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824847521
**[Test build #137790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137790/testReport)** for PR 32290 at commit [`176b883`](https://github.com/apache/spark/commit/176b883f9dcc7092b989b866cd9510cbdf76ba7c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a change in pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
sigmod commented on a change in pull request #32290:
URL: https://github.com/apache/spark/pull/32290#discussion_r618169819
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -506,6 +506,18 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
checkKeywordsExistsInExplain(df2, keywords = "[key1=value1, KEY2=VALUE2]")
}
}
+
+ test("SPARK-35183: CombineConcats should call transformAllExpressions") {
Review comment:
Done. Reverted.
(The explain test was copied and modified from another [one](https://github.com/apache/spark/blob/f208d808819dae38739fa9acda9510a4b9763dde/sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala#L151-L159) testing the original rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
sigmod commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824612270
@maropu @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824636476
**[Test build #137790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137790/testReport)** for PR 32290 at commit [`176b883`](https://github.com/apache/spark/commit/176b883f9dcc7092b989b866cd9510cbdf76ba7c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [WIP][SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824608760
**[Test build #137789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137789/testReport)** for PR 32290 at commit [`3580dd4`](https://github.com/apache/spark/commit/3580dd4bdbd6303433c080f8478bfc973461fb3b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824791057
**[Test build #137789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137789/testReport)** for PR 32290 at commit [`3580dd4`](https://github.com/apache/spark/commit/3580dd4bdbd6303433c080f8478bfc973461fb3b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824608760
**[Test build #137789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137789/testReport)** for PR 32290 at commit [`3580dd4`](https://github.com/apache/spark/commit/3580dd4bdbd6303433c080f8478bfc973461fb3b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824792975
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137789/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824636476
**[Test build #137790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137790/testReport)** for PR 32290 at commit [`176b883`](https://github.com/apache/spark/commit/176b883f9dcc7092b989b866cd9510cbdf76ba7c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824685869
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824713105
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824874925
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137790/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824706773
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824712735
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32290:
URL: https://github.com/apache/spark/pull/32290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824792975
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137789/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824689960
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824712735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32290:
URL: https://github.com/apache/spark/pull/32290#discussion_r618164295
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -506,6 +506,18 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
checkKeywordsExistsInExplain(df2, keywords = "[key1=value1, KEY2=VALUE2]")
}
}
+
+ test("SPARK-35183: CombineConcats should call transformAllExpressions") {
Review comment:
It's a bit weird to check the plan using explain result. If we want to have an end-to-end test for this optimization, let's check `sql(...).queryExecution.optimizedPlan` directly.
Normally we only write UT to test optimizer changes, so I'm fine to not have an end-to-end test here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a change in pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
sigmod commented on a change in pull request #32290:
URL: https://github.com/apache/spark/pull/32290#discussion_r618169819
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -506,6 +506,18 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
checkKeywordsExistsInExplain(df2, keywords = "[key1=value1, KEY2=VALUE2]")
}
}
+
+ test("SPARK-35183: CombineConcats should call transformAllExpressions") {
Review comment:
Done. Reverted.
(The explain test was copied and modified from another [one](https://github.com/apache/spark/blob/f208d808819dae38739fa9acda9510a4b9763dde/sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala#L151-L159) testing the original rule :-))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824874925
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137790/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824861847
late lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824713075
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32290: [SPARK-35183][SQL] Use transformAllExpressions in CombineConcats
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32290:
URL: https://github.com/apache/spark/pull/32290#issuecomment-824828085
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org