[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5029: Flink: Use Tag or Branch to scan data.

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #5029:
URL: https://github.com/apache/iceberg/pull/5029#discussion_r1103991645


##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##########
@@ -86,11 +87,23 @@ static CloseableIterable<CombinedScanTask> planTasks(
       IncrementalAppendScan scan = table.newIncrementalAppendScan();
       scan = refineScanWithBaseConfigs(scan, context, workerPool);
 
+      if (context.startTag() != null && table.snapshot(context.startTag()) != null) {

Review Comment:
   we should add Preconditions check for `table.snapshot(context.startTag())`. Invalid reference should result in an exception. this applies to other refs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org