[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy

["Pierre Smits (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048488#comment-17048488 ] 

Pierre Smits commented on OFBIZ-11030:
--------------------------------------

[~sberg]
In 'loadSalesInvoiceItemFact' you have:
{code:java}
 // conversion of the invoice currency
            if (UtilValidate.isNotEmpty(invoiceItem.productId)) {
                inMap = [:]
                naturalKeyFields = [:]
                inMap.dimensionEntityName = "CurrencyDimension"
{code}

This is not correct. 
{code:java}
if (UtilValidate.isNotEmpty(invoiceItem.productId)) {
{code}
This is not correct. Value retrieved should be from the 'currencyUomId' of the invoice.




> Convert FactServices.xml minilang to groovy
> -------------------------------------------
>
>                 Key: OFBIZ-11030
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11030
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: bi
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Sebastian Berg
>            Priority: Major
>              Labels: Fact, dwh, services
>         Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-InventoryItemFact-DemoTrunk.png, OFBIZ-11030-InventoryItemFact-test.png, OFBIZ-11030-Order-SalesOrder-overview.png, OFBIZ-11030-SalesInvoiceItemFact-test.png, OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert FactServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)