You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/09 10:54:13 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #17019: [fix][client] Release semaphore before discarding messages in batchMessageContainer
RobertIndie opened a new pull request, #17019:
URL: https://github.com/apache/pulsar/pull/17019
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #17014
### Motivation
The root cause of #17014 is a race condition in the `batchMessageContainer` when discarding the messages and releasing the semaphore. We need to release semaphore first and then discard messages. Otherwise, the user may observe that the semaphore has not been released after receiving the callback of that message.
### Modifications
* Release semaphore before discarding messages in batchMessageContainer
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #17019: [fix][client] Release semaphore before discarding messages in batchMessageContainer
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17019:
URL: https://github.com/apache/pulsar/pull/17019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17019: [fix][client] Release semaphore before discarding messages in batchMessageContainer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17019:
URL: https://github.com/apache/pulsar/pull/17019#issuecomment-1211468232
@RobertIndie Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org