You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/27 07:32:40 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2283: sim: Add a config to test libcxx

xiaoxiang781216 commented on a change in pull request #2283:
URL: https://github.com/apache/incubator-nuttx/pull/2283#discussion_r531424483



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -59,8 +59,8 @@ ifeq ($(CONFIG_CXX_EXCEPTION),)
   ARCHCPUFLAGSXX += -fno-exceptions
 endif
 ARCHPICFLAGS = -fpic
-ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
-ARCHWARNINGSXX = -Wall -Wshadow -Wundef
+ARCHWARNINGS = -Wstrict-prototypes -Wundef
+ARCHWARNINGSXX = -Wundef

Review comment:
       Yes, it isn't required for libc++, but I have saw other 3rd party library can't be the warning free with -Wall, and it's hard to disable -Wall by CFLAGS. Do you hit some special issue without -Wall?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org