You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/02 06:32:17 UTC
[GitHub] [incubator-eventmesh] walterlife commented on a diff in pull request #2303: [ISSUE #2196] [Workflow] Add prometheus metrics
walterlife commented on code in PR #2303:
URL: https://github.com/apache/incubator-eventmesh/pull/2303#discussion_r1036936623
##########
eventmesh-workflow-go/internal/task/event_task.go:
##########
@@ -43,6 +44,7 @@ func NewEventTask(instance *model.WorkflowTaskInstance) Task {
}
func (t *eventTask) Run() error {
+ metrics.Inc("event_task", "total")
Review Comment:
the metric type, the metric name is recommended to be maintained in the constants file
@horoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org