[jira] [Comment Edited] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188836#comment-15188836 ] 

Chetan Mehrotra edited comment on OAK-3642 at 3/10/16 7:23 AM:
---------------------------------------------------------------

[~alex.parvulescu] I see 2 options here
# We change the default - This would require figuring out broken test and fixing them (> 100)
# OR We expose a setting in {{Oak}} class which is then passed on to {{IndexUpdate}} regarding fail on missing provider. Then application which configure Oak can set it. In our case we make use of it in {{org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager}}. [patch|^OAK-3642-oak-config.patch] attached
{code}
        Oak oak = new Oak()
                .with(new OpenSecurityProvider())
                .with(new InitialContent())
                .with(wb)
                .with(wbProvider)
                .withFailOnMissingIndexProvider();
{code}

Thoughts?


was (Author: chetanm):
[~alex.parvulescu] I see 2 options here
# We change the default - This would require figuring out broken test and fixing them (> 100)
# OR We expose a setting in {{Oak}} class which is then passed on to {{IndexUpdate}} regarding fail on missing provider. Then application which configure Oak can set it. In our case we make use of it in {{org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager}}
{code}
        Oak oak = new Oak()
                .with(new OpenSecurityProvider())
                .with(new InitialContent())
                .with(wb)
                .with(wbProvider)
                .withFailOnMissingIndexProvider();
{code}

Thoughts?

> Enable failing of commit upon Missing IndexEditor implementation by default
> ---------------------------------------------------------------------------
>
>                 Key: OAK-3642
>                 URL: https://issues.apache.org/jira/browse/OAK-3642
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.6
>
>         Attachments: OAK-3642-oak-config.patch, OAK-3642.patch
>
>
> With OAK-3505 we exposed config option to enable failing of commit if any IndexEditor is missing. The default should be changed to always fail the commit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)