You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org> on 2018/10/08 17:48:29 UTC
[Impala-ASF-CR] Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11616
Change subject: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
This reverts commit 0e1de31ba56bdac73b8db5c5ff316334c84725d9.
Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 25 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/11616/1
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3292/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 08 Oct 2018 18:33:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11616
to look at the new patch set (#2).
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
This reverts commit 0e1de31ba56bdac73b8db5c5ff316334c84725d9.
Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 25 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/11616/2
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 08 Oct 2018 18:33:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
This reverts commit 0e1de31ba56bdac73b8db5c5ff316334c84725d9.
Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Reviewed-on: http://gerrit.cloudera.org:8080/11616
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 25 insertions(+), 86 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 1: Code-Review+2
Should be ok if its a clean revert
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 08 Oct 2018 18:13:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 08 Oct 2018 18:31:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 08 Oct 2018 22:19:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11616 )
Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/982/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4034a4323be741bc7d9fffcf17288aeb3649b31
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 08 Oct 2018 18:29:00 +0000
Gerrit-HasComments: No