You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/22 19:28:36 UTC

[GitHub] [airflow] BasPH commented on a change in pull request #5634: [AIRFLOW-5012][WIP] Add typehints for gcp_*_hook.py

BasPH commented on a change in pull request #5634: [AIRFLOW-5012][WIP] Add typehints for gcp_*_hook.py
URL: https://github.com/apache/airflow/pull/5634#discussion_r305993856
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_transfer_hook.py
 ##########
 @@ -410,15 +431,15 @@ def operations_contain_expected_statuses(operations, expected_statuses):
             with a state in the list,
         :rtype: bool
         """
-        expected_statuses = (
+        expected_statuses_set = (
 
 Review comment:
   Not a fan of placing types in the variable name, is that really needed? Other than that, seems like a hell of a job. Great work!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services