[jira] [Commented] (HADOOP-12772) NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values

["Kuhu Shukla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134771#comment-15134771 ] 

Kuhu Shukla commented on HADOOP-12772:
--------------------------------------

Thank you [~kihwal], moved the JIRA. 

The test failures are not seen locally and also are unrelated to this change. The {{TestReloadingX509TrustManager}} failure seems  to b documented by HADOOP-10823. Requesting for comments/review. Thank you very much.

> NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12772
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12772
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>            Priority: Minor
>         Attachments: HDFS-9762.001.patch, HDFS-9762.002.patch, HDFS-9762.003.patch
>
>
> Although the DatanodInfo/DataNodeDescriptor object tends to have a non-null, non-empty value for its network location, the getNodeGroup method does not handle the case if an empty or a null value is passed and can go on recursively causing StackOverflowError. This is an improvement to check for such a state and error out if the value is null and set the location to ROOT or empty string and if the original location is empty. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)