You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2017/06/08 23:47:34 UTC
[GitHub] activemq-artemis pull request #1328: ARTEMIS-1205: AMQP Shared Durable Subsc...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1328
ARTEMIS-1205: AMQP Shared Durable Subscriber incorrect behaviour
adding support into Artemis Client to support AMQP compatibility with escape behaviour.
adding test, and ensuring unsubscirbe works as per spec for AMQP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1205
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1328
----
commit ac914f27f9d5d042bcebfc1c93833fca5cdc4ec6
Author: Michael Andre Pearce <mi...@me.com>
Date: 2017-06-08T19:38:09Z
ARTEMIS-1205: AMQP Shared Durable Subscriber incorrect behaviour
adding support into Artemis Client to support AMQP compatibility with escape behaviour.
adding test, and ensuring unsubscirbe works as per spec for AMQP
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1328: ARTEMIS-1205: AMQP Shared Durable Subscriber i...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1328
@jbertram Based on discussion https://github.com/apache/activemq-artemis/pull/1316 i have also raise an alternative solution, thats server side. If you can hold merging till we get a semi-acceptance of either the approach currently doing or if we go with the alternative i just raised (i suspect the alternative might end up being the one people are more happy with).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1328: ARTEMIS-1205: AMQP Shared Durable Subscriber i...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1328
@gemmellr @jbertram im closing this one now, based on we are agreed we are going with https://github.com/apache/activemq-artemis/pull/1337
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1328: ARTEMIS-1205: AMQP Shared Durable Subsc...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1328: ARTEMIS-1205: AMQP Shared Durable Subscriber i...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1328
Couple of things...
* The methods createQueueNameForLegacySubscription and createQueueNameForAmqpCompatibleSubscription in org.apache.activemq.artemis.jms.client.ActiveMQDestination are almost exactly the same. I'd rather not have that kind of code duplication. You could just replace the logic in createQueueNameForSubscription with the logic from createQueueNameForLegacySubscription and refactor escape to take the amqpCompatibleQueues boolean. That's just one way to do; there's lots of ways to avoid the code duplication here.
* I know it's tempting to make unrelated but worthwhile changes in a PR (e.g. removing the unused method decomposeQueueNameForDurableSubscription). I've done it myself. However, it makes the diff harder to read and understand since the change isn't clearly related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1328: ARTEMIS-1205: AMQP Shared Durable Subscriber i...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1328
@jbertram thanks for the feedback, reverted back unused methods, and also removed the duplication.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---