[GitHub] ThomasDelteil commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export

[GitBox <gi...@apache.org>]

ThomasDelteil commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export
URL: https://github.com/apache/incubator-mxnet/pull/11213#discussion_r194631489
 
 

 ##########
 File path: python/mxnet/contrib/onnx/_export/export_helper.py
 ##########
 @@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""export helper functions"""
+# coding: utf-8
+import os
+import logging
+import mxnet as mx
+
+def load_module(sym_filepath, params_filepath, input_shape):
 
 Review comment:
   Question: what is the purpose of this function why couldn't it be replaced by a simple:
   ```
   sym = mx.sym.load(sym_filepath)
   params = mx.nd.load(params_filepath)
   return sym, params
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services