You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/19 04:07:04 UTC
[kudu-CR] tool: basic integration test
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4058
to review the following change.
Change subject: tool: basic integration test
......................................................................
tool: basic integration test
So far all it does is spot check some help pages, but in the future we
should augment it to test functionality too. For now that's not a big deal
because every tool function is covered in either master_migration-itest or
master_failover-itest.
Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
---
M src/kudu/tools/CMakeLists.txt
A src/kudu/tools/kudu-tool-test.cc
2 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/4058/1
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: basic integration test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4058
to look at the new patch set (#4).
Change subject: tool: basic integration test
......................................................................
tool: basic integration test
So far all it does is spot check some help pages, but in the future we
should augment it to test functionality too. For now that's not a big deal
because every tool function is covered in either master_migration-itest or
master_failover-itest.
Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
---
M build-support/dist_test.py
M src/kudu/tools/CMakeLists.txt
A src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/test_macros.h
4 files changed, 188 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/4058/4
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: basic integration test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4058/4/src/kudu/util/test_macros.h
File src/kudu/util/test_macros.h:
Line 89: matched = true; \
> nit:tabs
Done
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: basic integration test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: tool: basic integration test
......................................................................
tool: basic integration test
So far all it does is spot check some help pages, but in the future we
should augment it to test functionality too. For now that's not a big deal
because every tool function is covered in either master_migration-itest or
master_failover-itest.
Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Reviewed-on: http://gerrit.cloudera.org:8080/4058
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M build-support/dist_test.py
M src/kudu/tools/CMakeLists.txt
A src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/test_macros.h
4 files changed, 188 insertions(+), 3 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: basic integration test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2999/
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: basic integration test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/3058/
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: basic integration test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2998/
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: basic integration test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/3065/
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: basic integration test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4058/3/build-support/dist_test.py
File build-support/dist_test.py:
Line 249: deps.extend(ldd_deps(d))
do we need to worry about de-duping deps now?
http://gerrit.cloudera.org:8080/#/c/4058/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
PS3, Line 70: expected_prefixes
don't really understand the usage here
Line 91: // Strip away everything up to the usage string to test for prefixes.
a little skeptical of this fancy verification vs just hard-coding a regex for each help output -- may be easier to maintain the test that way
Line 99: if (l.find(" " + m) != string::npos) {
this isn't checking for a prefix
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: basic integration test
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2987/
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: basic integration test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4058
to look at the new patch set (#3).
Change subject: tool: basic integration test
......................................................................
tool: basic integration test
So far all it does is spot check some help pages, but in the future we
should augment it to test functionality too. For now that's not a big deal
because every tool function is covered in either master_migration-itest or
master_failover-itest.
Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
---
M build-support/dist_test.py
M src/kudu/tools/CMakeLists.txt
A src/kudu/tools/kudu-tool-test.cc
3 files changed, 145 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/4058/3
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: basic integration test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4058/3/build-support/dist_test.py
File build-support/dist_test.py:
Line 249: deps.extend(ldd_deps(d))
> do we need to worry about de-duping deps now?
Since all of the tests passed I can't tell whether we actually shipped duplicate dependencies, but I'll deduplicate here.
http://gerrit.cloudera.org:8080/#/c/4058/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
PS3, Line 70: expected_prefixes
> don't really understand the usage here
Replaced this with regexes, so it's a moot point now.
Line 91: // Strip away everything up to the usage string to test for prefixes.
> a little skeptical of this fancy verification vs just hard-coding a regex f
Done
Line 99: if (l.find(" " + m) != string::npos) {
> this isn't checking for a prefix
Done
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: basic integration test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4058
to look at the new patch set (#5).
Change subject: tool: basic integration test
......................................................................
tool: basic integration test
So far all it does is spot check some help pages, but in the future we
should augment it to test functionality too. For now that's not a big deal
because every tool function is covered in either master_migration-itest or
master_failover-itest.
Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
---
M build-support/dist_test.py
M src/kudu/tools/CMakeLists.txt
A src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/test_macros.h
4 files changed, 188 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/4058/5
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: basic integration test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4058
to look at the new patch set (#2).
Change subject: tool: basic integration test
......................................................................
tool: basic integration test
So far all it does is spot check some help pages, but in the future we
should augment it to test functionality too. For now that's not a big deal
because every tool function is covered in either master_migration-itest or
master_failover-itest.
Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
---
M build-support/dist_test.py
M src/kudu/tools/CMakeLists.txt
A src/kudu/tools/kudu-tool-test.cc
3 files changed, 145 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/4058/2
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: basic integration test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4058/4/src/kudu/util/test_macros.h
File src/kudu/util/test_macros.h:
Line 89: matched = true; \
nit:tabs
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: basic integration test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tool: basic integration test
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib386882c1874e987d5824cfe742cc86627cd9eaa
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No