You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/11/05 12:56:37 UTC

Review Request 27613: sync Job Failures always reported as success on Event Bus

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27613/
-----------------------------------------------------------

Review request for cloudstack, Kishan Kavala and Koushik Das.


Bugs: CLOUDSTACK-7843
    https://issues.apache.org/jira/browse/CLOUDSTACK-7843


Repository: cloudstack-git


Description
-------

As complete async job event gets published before saving the job status to the database. so it is not putting correct job status into event bus while publishing.


Diffs
-----

  framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java 548182a 

Diff: https://reviews.apache.org/r/27613/diff/


Testing
-------


Thanks,

Damodar Reddy Talakanti


Re: Review Request 27613: sync Job Failures always reported as success on Event Bus

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27613/#review60557
-----------------------------------------------------------


4.5 cdabb2407a0761939d5159fd2317ebd7dcca4eb7

- Kishan Kavala


On Nov. 5, 2014, 5:26 p.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27613/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 5:26 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-7843
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7843
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> As complete async job event gets published before saving the job status to the database. so it is not putting correct job status into event bus while publishing.
> 
> 
> Diffs
> -----
> 
>   framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java 548182a 
> 
> Diff: https://reviews.apache.org/r/27613/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 27613: sync Job Failures always reported as success on Event Bus

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27613/#review60551
-----------------------------------------------------------

Ship it!


Master: ca66062cd54305afaaa64d707a88fc11764e292d

- Kishan Kavala


On Nov. 5, 2014, 5:26 p.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27613/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 5:26 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-7843
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7843
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> As complete async job event gets published before saving the job status to the database. so it is not putting correct job status into event bus while publishing.
> 
> 
> Diffs
> -----
> 
>   framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java 548182a 
> 
> Diff: https://reviews.apache.org/r/27613/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>