[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2512: [SCB-1715] Fix idleTimeout not work in client side without keepaliveTimeout set

[GitBox <gi...@apache.org>]

david6969xin commented on a change in pull request #2512:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2512#discussion_r690367741



##########
File path: transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##########
@@ -73,31 +73,23 @@ public void init(Vertx vertx) throws Exception {
     VertxUtils.blockDeploy(vertx, ClientVerticle.class, deployOptionshttp2);
   }
 
-  private static HttpClientOptions createHttpClientOptions() {
+  private static HttpClientOptions createHttpClientOptions(boolean http2) {
     HttpClientOptions httpClientOptions = new HttpClientOptions();
-    httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
-        .setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+    httpClientOptions.setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org